Skip to content

DAOS-17754 bio: store ctrlr data in SMD - #16886

Merged
NiuYawei merged 3 commits into
masterfrom
niu/DAOS-17754
Oct 11, 2025
Merged

DAOS-17754 bio: store ctrlr data in SMD#16886
NiuYawei merged 3 commits into
masterfrom
niu/DAOS-17754

Conversation

@NiuYawei

@NiuYawei NiuYawei commented Sep 19, 2025

Copy link
Copy Markdown
Contributor

Store SSD model & serial number in SMD, that information could help user to identify which SSD is not plugged or plugged in wrong PCIe slot.

Steps for the author:

  • Commit message follows the guidelines.
  • Appropriate Features or Test-tag pragmas were used.
  • Appropriate Functional Test Stages were run.
  • At least two positive code reviews including at least one code owner from each category referenced in the PR.
  • Testing is complete. If necessary, forced-landing label added and a reason added in a comment.

After all prior steps are complete:

  • Gatekeeper requested (daos-gatekeeper added as a reviewer).

@github-actions

github-actions Bot commented Sep 19, 2025

Copy link
Copy Markdown

Ticket title is 'Improve DAOS Engine Error Reporting for Missing SSDs After Slot Reassignment'
Status is 'In Progress'
https://daosio.atlassian.net/browse/DAOS-17754

@daosbuild3

daosbuild3 commented Sep 19, 2025

Copy link
Copy Markdown
Collaborator

Test stage Unit Test on EL 8.8 completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-16886/1/testReport/

@daosbuild3

daosbuild3 commented Sep 19, 2025

Copy link
Copy Markdown
Collaborator

Test stage Unit Test with memcheck on EL 8.8 completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-16886/1/testReport/

tanabarr
tanabarr previously approved these changes Sep 19, 2025
View reviewed changes

@tanabarr tanabarr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NiuYawei
DAOS-17754 bio: store ctrlr data in SMD
f25c946 
Store SSD model & serial number in SMD, that information could
help user to identify which SSD is not plugged or plugged in
wrong PCIe slot.

Signed-off-by: Niu Yawei <yawei.niu@hpe.com>
@NiuYawei
NiuYawei marked this pull request as ready for review September 25, 2025 06:39
@NiuYawei
NiuYawei requested review from a team as code owners September 25, 2025 06:39
wangshilong
wangshilong reviewed Sep 25, 2025
View reviewed changes
Comment thread src/bio/bio_xstream.c
"Device: " DF_UUID " "
"[model:%s, serial:%s] for target:%d type:%d is unplugged\n",
DP_UUID(dev_info->sdi_id), dev_info->sdi_model,
dev_info->sdi_serial, tgt_id, st);

@wangshilong wangshilong Sep 25, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will it cause segfault if sdi_model or sdi_serial is NULL? or we gurante this two values are not NULL.

@NiuYawei NiuYawei Sep 25, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NULL string can be handled by printf, right?

@wangshilong wangshilong Sep 25, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right, sorry for noise.

wangshilong
wangshilong previously approved these changes Sep 25, 2025
View reviewed changes
tanabarr
tanabarr previously approved these changes Sep 25, 2025
View reviewed changes
Comment thread src/bio/smd/smd_internal.h

#define TABLE_DEV "device"
#define SMD_DEV_NAME_MAX 16
#define TABLE_CTRLR_DATA "ctrlr_data"

@tanabarr tanabarr Sep 25, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: strange alignment

@NiuYawei
NiuYawei dismissed stale reviews from tanabarr and wangshilong via 9289b46 October 9, 2025 06:07
@daosbuild3

daosbuild3 commented Oct 9, 2025

Copy link
Copy Markdown
Collaborator

Test stage Test RPMs on EL 8.6 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos/job/PR-16886/3/display/redirect

@daosbuild3

daosbuild3 commented Oct 9, 2025

Copy link
Copy Markdown
Collaborator

Test stage Functional on EL 8.8 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos/job/PR-16886/3/display/redirect

@daosbuild3

daosbuild3 commented Oct 10, 2025

Copy link
Copy Markdown
Collaborator

Test stage Functional Hardware Medium MD on SSD completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-16886/4/execution/node/792/log

@daosbuild3

daosbuild3 commented Oct 10, 2025

Copy link
Copy Markdown
Collaborator

Test stage Functional Hardware Medium Verbs Provider MD on SSD completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-16886/4/execution/node/764/log

@NiuYawei
NiuYawei merged commit e169b81 into master Oct 11, 2025
41 checks passed
@NiuYawei
NiuYawei deleted the niu/DAOS-17754 branch October 11, 2025 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wangshilong wangshilong wangshilong approved these changes
@sherintg sherintg sherintg approved these changes
@tanabarr tanabarr Awaiting requested review from tanabarr

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@NiuYawei @daosbuild3 @tanabarr @wangshilong @sherintg