Skip to content

Fix Debian ISO installs failing on the cdrom APT source #734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Marketen merged 2 commits into from
Oct 8, 2026
Merged

Fix Debian ISO installs failing on the cdrom APT source #734

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
902984c
Fix Debian ISO installs failing on the cdrom APT source
Marketen Oct 8, 2026
897800b
Merge branch 'master' into marc/fix-iso-cdrom-apt-update
Marketen Oct 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions scripts/dappnode_install_pre.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,8 +107,21 @@ install_iptables() {
fi
}

# The Debian installer comments out the install media's cdrom: APT source only
# after the late-commands have run. Until then apt-get update fails on it, so
# disable it now as the installer would (apt-setup/disable-cdrom-entries).
disable_iso_cdrom_sources() {
[ "$ISO_INSTALLATION" = "true" ] || return 0
local sources_file
for sources_file in /etc/apt/sources.list /etc/apt/sources.list.d/*.list; do
[ -f "$sources_file" ] || continue
sed -i -E 's/^(deb(-src)?[[:space:]]+(\[[^]]*\][[:space:]]+)?cdrom:)/# \1/' "$sources_file"
done
}

# HOST UPDATE
host_update() {
disable_iso_cdrom_sources
# Process substitution keeps apt-get's exit status while still logging its
# output. A regular pipeline would return tee's status and hide dpkg errors.
apt-get update > >(tee -a "$LOG_FILE") 2>&1 || return $?
Expand Down
Loading