Skip to content

Wait for the network before fetching IPFS manifests on first boot #735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Marketen merged 2 commits into from
Oct 8, 2026
Merged

Wait for the network before fetching IPFS manifests on first boot #735

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
70cceb4
Wait for the network before fetching IPFS manifests on first boot
Marketen Oct 8, 2026
7587ea2
Merge branch 'master' into marc/fix-firstboot-ipfs-manifest-race
Marketen Oct 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion scripts/dappnode_install.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -428,7 +428,17 @@ normalize_ipfs_version_ref() {
local cid_path="$ref"
local manifest_url="${IPFS_ENDPOINT%/}${cid_path}/dappnode_package.json"
local manifest
manifest="$(download_stdout "$manifest_url" 2>/dev/null || true)"
# On the first boot after an ISO install this runs from rc.local, which
# does not wait for DHCP (Debian's allow-hotplug interfaces are not part
# of network-online.target), so give the network up to ~2 minutes.
local attempt
for attempt in $(seq 1 24); do
manifest="$(download_stdout "$manifest_url" 2>/dev/null || true)"
[[ -n "$manifest" ]] && break
# stdout is this function's return value, so report on stderr
[[ "$attempt" -eq 1 ]] && warn "Could not fetch IPFS manifest for ${comp} yet, retrying..." >&2
[[ "$attempt" -lt 24 ]] && sleep 5
done
if [[ -z "$manifest" ]]; then
error "Could not fetch IPFS manifest for ${comp} from: $manifest_url"
error "Provide ${comp}_VERSION as /ipfs/<cid>:<version> (example: /ipfs/Qm...:0.2.11)"
Expand Down
Loading