Conversation
Signed-off-by: somaz <genius5711@gmail.com>
somaz94
added a commit
to somaz94/somaz94
that referenced
this pull request
Sep 22, 2026
…489 and dapr/cli#1710 to OSS contributions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
dapr workflow list,history,purgeandrerunfailed withUnauthenticatedagainst a sidecar secured with an API token, even withDAPR_API_TOKENexported.The workflow client dialed its own gRPC connection next to the SDK client, so it never got the SDK interceptor that attaches the
dapr-api-tokenheader. It now reuses the SDK client's connection, the same waydapr workflow runand the event commands already do. This covers both self-hosted and Kubernetes mode.Closing the SDK client in
Cancelnow also closes that shared connection, which was never closed before. In Kubernetes mode the port-forward is stopped if connecting fails.I added a test that starts a fake sidecar with
DAPR_API_TOKENset and checks that the token arrives on a workflow call. It fails on master and passes with this change.go test ./pkg/...andgolangci-lint run ./pkg/workflow/...are clean locally.Issue reference
Please reference the issue this PR will close: #1700
Checklist