Skip to content

Close the event loop invoke_method creates for itself #1215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
magic-peach wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Close the event loop invoke_method creates for itself #1215

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion dapr/clients/http/dapr_invocation_http_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,11 +157,17 @@ def invoke_method(

try:
loop = asyncio.get_running_loop()
owns_loop = False
except RuntimeError:
loop = asyncio.new_event_loop()
owns_loop = True
asyncio.set_event_loop(loop)

awaitable = self.invoke_method_async(
app_id, method_name, data, content_type, metadata, http_verb, http_querystring, timeout
)
return loop.run_until_complete(awaitable)
try:
return loop.run_until_complete(awaitable)
finally:
if owns_loop:
loop.close()
15 changes: 15 additions & 0 deletions tests/clients/test_http_service_invocation_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,21 @@ def test_basic_invoke(self):
self.assertEqual(b'STRING_BODY', response.data)
self.assertEqual(self.invoke_url, self.server.request_path())

def test_invoke_closes_the_event_loop_it_creates(self):
self.server.set_response(b'STRING_BODY')

import asyncio
import warnings

with warnings.catch_warnings(record=True) as caught:
warnings.simplefilter('always')
self.client.invoke_method(self.app_id, self.method_name, '')
self.client.invoke_method(self.app_id, self.method_name, '')

unclosed_loop_warnings = [w for w in caught if 'unclosed event loop' in str(w.message)]
self.assertEqual([], unclosed_loop_warnings)
self.assertTrue(asyncio.get_event_loop_policy().get_event_loop().is_closed())

def test_coroutine_basic_invoke(self):
self.server.set_response(b'STRING_BODY')

Expand Down