Skip to content

Fix get_state_names omitting untouched initstate keys in MockStateManager #1216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
magic-peach wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix get_state_names omitting untouched initstate keys in MockStateManager #1216

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions dapr/actor/runtime/mock_state_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,13 +192,10 @@ async def add_or_update_state(
return value

async def get_state_names(self) -> List[str]:
# TODO: Get all state names from Dapr once implemented.
# _mock_state is kept in sync with every add/set/remove, including states
# seeded via initstate that the tracker never sees, so it's the source of truth.
def append_names_sync():
return [
key
for key, value in self._default_state_change_tracker.items()
if value.change_kind != StateChangeKind.remove
]
return list(self._mock_state.keys())

default_loop = asyncio.get_running_loop()
return await default_loop.run_in_executor(None, append_names_sync)
Expand Down
11 changes: 11 additions & 0 deletions tests/actor/test_mock_state_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,17 @@ async def test_get_state_names_excludes_only_removed(self):

self.assertCountEqual(names, ['state'])

async def test_get_state_names_includes_untouched_initstate(self):
"""A state seeded via initstate but never read or written this turn
never enters the change tracker, so get_state_names must still
report it since contains_state already does."""
mock_actor = create_mock_actor(MockTestActor, 'test', {'state': 5, 'other': 6})
state_manager = mock_actor._state_manager

names = await state_manager.get_state_names()

self.assertCountEqual(names, ['state', 'other'])

async def test_readd_after_remove_updates_mock_state(self):
"""try_add_state on a state removed earlier this turn must make the
new value visible in _mock_state, matching add_or_update_state's
Expand Down