script_manager: use SVG for the start/stop button icons - #715
Open
andriiryzhkov wants to merge 1 commit into
Open
script_manager: use SVG for the start/stop button icons#715andriiryzhkov wants to merge 1 commit into
andriiryzhkov wants to merge 1 commit into
Conversation
The power and blank icons were 20x21 PNGs, so they were upscaled and soft on a HiDPI screen and stayed 20px whatever the interface font size. As SVG they are rendered at whatever size is asked for. Geometry is taken from dtgtk_cairo_paint_switch() so the button matches darktable's own switch icon, with a margin inside the viewBox so the symbol does not touch the button border.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
path20.pngandblank20.pngare 20x21 bitmaps, so the start/stop buttons are upscaled and soft on a HiDPI screen and stay 20px whatever the interface font size is.power.svgandblank.svgrender at whatever size darktable asks for.The geometry comes from
dtgtk_cairo_paint_switch()so the button reads as darktable's own switch icon. The viewBox carries a margin, since the Lua button sizes itself to its content and has no padding of its own. Stroke width was picked by eye: darktable's switch is drawn at a fixed device-pixel width, which an SVG cannot match at every scale.The old PNGs are now unreferenced but left in place – happy to drop them here if preferred.
Needs darktable#22229. Without it
gtk_image_new_from_file()hands back a 48x48 pixbuf for a 24px SVG on a scale-2 display and lays it out at 48 logical px, against the PNG's 20.Written with AI assistance.