Container audit loses the repository identity: git refuses the mounted repo (dubious ownership) #586

With the documented command, docker run --rm -v "$PWD:/repo" <image> audit, on Linux:

Platform API call /repos//repo/releases?per_page=5 could not be measured (unavailable)
handler github_branch_protection needs owner/repo (from context or config)
Trust: unknown repository untrusted (no repository identity)

The owner is empty and the name is the mount directory (repo), so every platform check fails.

The cause is the container runs as uid 10001. The mounted repository belongs to the host user. git refuses it:

$ git -C /repo remote get-url origin
fatal: detected dubious ownership in repository at '/repo'

Confirmed workaround

docker run --rm -v "$PWD:/repo" \
  -e GIT_CONFIG_COUNT=1 -e GIT_CONFIG_KEY_0=safe.directory -e GIT_CONFIG_VALUE_0=/repo \
  <image> audit

With this, git returns the remote and the audit calls /repos/darnitdevorg/darnit/....

Possible fix

Set safe.directory=/repo in the image (Dockerfile ENV or the entrypoint). This turns off git's ownership check for the mounted repo, so it is worth a short look at what a hostile .git/config could do inside the container. The alternative is to document --user "$(id -u):$(id -g)", which I have not tested.

Related

• fix(sieve): do not call the platform without a repository identity #579 stops the /repos//name call when the identity is empty. It does not give the container the identity.
• docs/install/container.md does not say that platform checks need -e GH_TOKEN.

Seen on RHEL 10 with podman (rootful), image built from the #519 branch.