Repository navigation
fix: restore the txindex requirement when governance validation is enabled #7785
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
PastaPastaPasta
merged 1 commit into
dashpay:develop
from
PastaPastaPasta:fix/restore-the-txindex-requirement-when-governance
Oct 5, 2026
+43
−0
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| #!/usr/bin/env python3 | ||
| # Copyright (c) 2026 The Dash Core developers | ||
| # Distributed under the MIT software license, see the accompanying | ||
| # file COPYING or http://www.opensource.org/licenses/mit-license.php. | ||
| """Test that a node refuses to run governance validation without the transaction index outside regtest. | ||
|
|
||
| Regtest exempts nodes from this check, so it is exercised on devnet here. | ||
| """ | ||
|
|
||
| from test_framework.governance import EXPECTED_STDERR_NO_GOV | ||
| from test_framework.test_framework import BitcoinTestFramework | ||
|
|
||
|
|
||
| class GovernanceTxindexDevnetTest(BitcoinTestFramework): | ||
| def set_test_params(self): | ||
| self.setup_clean_chain = True | ||
| self.chain = "devnet" | ||
| self.num_nodes = 1 | ||
|
|
||
| def run_test(self): | ||
| self.stop_node(0) | ||
|
|
||
| self.log.info("Test that -txindex=0 is refused while governance validation is enabled") | ||
| self.nodes[0].assert_start_raises_init_error( | ||
| extra_args=["-txindex=0"], | ||
| expected_msg="Error: Transaction index can't be disabled with governance validation enabled. " | ||
| "Either start with -disablegovernance command line switch or enable transaction index.") | ||
|
|
||
| self.log.info("Test that -txindex=0 is allowed together with -disablegovernance") | ||
| self.start_node(0, extra_args=["-txindex=0", "-disablegovernance"]) | ||
| self.stop_node(0, expected_stderr=EXPECTED_STDERR_NO_GOV) | ||
|
|
||
|
|
||
| if __name__ == '__main__': | ||
| GovernanceTxindexDevnetTest().main() | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: I'd move this scenario to test/functional/p2p_connect_to_devnet.py or test/functional/feature_masternode_params_devnet.py but that's fine for now