[knst]

Issue being fixed or feature implemented

develop CI is red since the merge of #7260 (aec4994). Both linux64_asan-build and linux64_multiprocess-build pass on the merge of #7790 (2ca083a) and on the head of #7584 (fed2f49), and both are red on the head of #7260 (3034e98) and on its merge commit. #7260 was merged with those two jobs failing.

1. linux64_asan fails in test_dash-qt: CoinControlTreeWidgetTests::disabledCoinsSkipped() triggers an UBSan implicit-integer-sign-change inside QFlags::operator&. The test, added by feat(qt): add shift-click range selection to coin control dialog #7260 in 3034e98, clears a flag with flags() & ~Qt::ItemIsEnabled. ~Qt::ItemIsEnabled is evaluated as a plain int (-33) and QFlags converts it to its unsigned storage type.

2. linux64_multiprocess reports a clang static analyzer diagnostic in test/block_reward_reallocation_tests.cpp:209: tip->nBits dereferences a pointer the analyzer considers possibly null, because GetMnRewardEraAfter() (via DeploymentActiveAfter()) accepts a null pindexPrev. The pattern dates back to refactor: drop circular dependency over validation <-> masternode/payment #7339 (7f2058e) and the file was last touched by refactor(utils): consolidate masternode test helpers #7536 in August, so this diagnostic is not caused by feat(qt): add shift-click range selection to coin control dialog #7260's diff. The analyzer runs in that job because the tidy step operates on the make distdir copy of the tree, which does not include src/.clang-tidy, so clang-tidy falls back to its default clang-analyzer-* checks. I could not read the job log (needs credentials) to confirm that this diagnostic alone fails the step, so this part is fixed on the evidence of the pasted output.

What was done?

• src/qt/test/coincontroltreewidgettests.cpp: clear the flag with flags().setFlag(Qt::ItemIsEnabled, false), which stays inside the QFlags type.
• src/test/block_reward_reallocation_tests.cpp: wrap every chain-tip lookup that feeds GetMnRewardEraAfter() in Assert() and include util/check.h. The chain is never empty at those points; the assertion documents it for the analyzer and the reader. This is test code, so a fatal check is acceptable.

How Has This Been Tested?

see CI

Breaking Changes

None.

Checklist:

• I have performed a self-review of my own code
• I have made corresponding changes to the documentation
• I have assigned this pull request to a milestone

[thepastaclaw]

🔍 Review in progress — actively reviewing now (commit 92365cc) · triage: low
███████████████████░ 93% · taking longer than usual · running for 50 min
✅ triage → ⏳ Phase 1 (0/1 lanes) → ▫️ verify 1 → ▫️ gate → ▫️ Phase 2 → ▫️ verify 2 → ▫️ publish
_{Estimated from recent reviews of this tier · updated 23:15 UTC · live progress}

[coderabbitai]

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

🧰 Additional context used

📚 Code guidelines (1)

doc/developer-notes.md — auto-discovered

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: Repository UI
• Review profile: CHILL
• Plan: Advanced
• Run ID: ee96fd93-4292-4602-aa8b-a8007aa1e4b4

📥 Commits

Reviewing files that changed from the base of the PR and between 9c6ccd0 and 92365cc.

📒 Files selected for processing (1)

• src/qt/test/coincontroltreewidgettests.cpp

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 2 remain after this review.

---

Walkthrough

AddCoins now reserves capacity for the requested number of coin pointers. The disabled-coin test clears Qt::ItemIsEnabled with setFlag. The reward-reallocation test includes util/check.h and asserts that seven active-chain tip lookups return non-null pointers.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~8 minutes

Merge Risk: ⚪ Minimal · up to 92365

These test-only changes clarify coin-control behavior and reward-test pointer assumptions without changing product behavior. No merge-blocking issue is evident; routine checks remain appropriate.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 2 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly summarizes the CI fixes and names the two reported issues. It is somewhat long, but remains specific and relevant.
Description check	✅ Passed	The description explains the CI failures, the changes made, and the reported testing context. It is directly related to the changeset.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

• Fix all pre-merge checks with AI

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create a new PR

• Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[PastaPastaPasta]

utACK