[PastaPastaPasta]

Issue being fixed or feature implemented

The Tests workflow on v5.1-dev has been red since #5296 merged v5.0-dev into it (run 37356617091):

shield_from_asset_lock::tests::tests::bundle_binding::
  should_refuse_a_version_0_at_protocol_version_14_without_touching_its_asset_lock
assertion `left == right` failed
  left: 15
  right: 14

The test came from #4760 on v5.0-dev, where the latest protocol version is 14. It runs at PlatformVersion::latest() and asserts that this equals 14. On v5.1-dev the latest version has been 15 since #5043, so the test fails even though no shielding code changed.

What was done?

• Changed the assertion to protocol_version >= 14. Version 0 is refused from protocol version 14 on.
• Left the rest of the test as it was. Its other checks already hold at any version from 14 up: the refusal reports required_protocol_version() == 13 and the current version, nothing is charged, the lock stays unspent and the v1 resubmission goes through.
• Kept the test name, so later v5.0-dev → v5.1-dev merges don't conflict on it.

How Has This Been Tested?

The test passes in this PR's CI, in the "Run shielded tests with cargo test" step of Rust workspace tests (run 37371982915).

Breaking Changes

None. Test-only change.

Checklist:

• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have added or updated relevant unit/integration/functional/e2e tests
• I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
• I have made corresponding changes to the documentation if needed

🤖 Generated with Claude Code

PR Hygiene · eff1944

• Bots — coderabbitai not yet · thepastaclaw ✓ — /skip-bots proceeds without the ones not yet reported
• Self-review — post /self-reviewed
• Within your 5 open PRs — this one is beyond the limit; it waits until one merges
• Build running
• Approvals
  • rs-drive-abci (packages/rs-drive-abci/src/execution/validation/state_transition/state_transitions/shield_from_asset_lock/tests.rs) — QuantumExplorer or shumkov

When every box is checked the PR Hygiene check passes and this can merge.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

• Configuration used: Repository: dashpay/platform/.coderabbit.yaml
• Review profile: CHILL
• Plan: Advanced
• Run ID: f7975e11-0f5c-4032-8601-1ca7fd689f33

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

• Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[thepastaclaw]

✅ Final review complete — no blockers (commit eff1944) · triage: low

[github-actions]

Waiting for bot review — coderabbitai not yet · thepastaclaw ✓. Wait for the missing reviews, or a writer can post /skip-bots to proceed without them; blocking findings still need addressing.
Full checklist in the description.

[thepastaclaw]

Final validation — Phase 1 + Phase 2

Verified the complete diff at eff1944 against the surrounding test, transition activation ranges, and protocol-version tables. The test-only relaxation correctly accommodates protocol version 15 while preserving the unpaid-refusal, untouched-asset-lock, successful-resubmission, and mempool-rejection assertions; no in-scope defects remain. Validation was static only, and Rust workspace tests were still queued in the supplied CI snapshot.

Review provenance

Source: reviewer 1: glm-5.3-flash (agent: phase1-reviewer, role: general); reviewer 2: glm-5.3-flash (agent: phase1-reviewer, role: rust-quality); reviewer 3: gpt-6.1-sol (agent: phase2-reviewer, role: general); reviewer 4: gpt-6.1-sol (agent: phase2-reviewer, role: architecture-layering); reviewer 5: gpt-6.1-sol (agent: phase2-reviewer, role: platform-versioning); reviewer 6: gpt-6.1-sol (agent: phase2-reviewer, role: rust-quality); final verifier: gpt-6.1-sol (agent: sol-verifier, role: final-verifier)

• Triage: low by gpt-6.1-sol (effort low) — This is a small, contained test assertion change from an exact protocol version to a minimum version, with no production behavior changes.
• Phase 1 reviewers: glm-5.3-flash — general (completed, effort high); agent phase1-reviewer, glm-5.3-flash — rust-quality (completed, effort high); agent phase1-reviewer
• Phase 1 model: glm-5.3-flash — zai quota: 5h 99% left, weekly 99% left; passed over gemini-3.8-flash-high (antigravity below 15% reserve: weekly 15% left, 5h 100% left)
• Fresh verifier: gpt-6.1-sol — final-verifier; agent sol-verifier
• Phase 2 reviewers: gpt-6.1-sol — general (completed, effort medium); agent phase2-reviewer, gpt-6.1-sol — architecture-layering (completed, effort medium); agent phase2-reviewer, gpt-6.1-sol — platform-versioning (completed, effort medium); agent phase2-reviewer, gpt-6.1-sol — rust-quality (completed, effort medium); agent phase2-reviewer

[PastaPastaPasta]

approved