Skip to content

build: fix the stale dash-core-proof version that fails every --locked build on v5.1-dev - #5650

Merged
PastaPastaPasta merged 1 commit into
v5.1-devfrom
fix/cargo-lock-dash-core-proof-version
Oct 29, 2026
Merged

PastaPastaPasta merged 1 commit into
v5.1-devfrom
fix/cargo-lock-dash-core-proof-version

Conversation

@PastaPastaPasta

@PastaPastaPasta PastaPastaPasta commented Oct 29, 2026 •

Copy link
Copy Markdown
Member

Issue being fixed or feature implemented

Every PR into v5.1-dev now fails Rust workspace tests before Clippy runs:

error: cannot update the lock file .../Cargo.lock because --locked was passed to prevent this

#5521 added dash-core-proof to Cargo.lock at 5.0.0-rc.4. Its CI ran against a v5.1-dev from before the 5.0.1 bump (#5606) came in through the v5.0-dev merge. The crate takes the workspace version, now 5.0.1, so the merged lockfile is stale.

What was done?

Regenerated Cargo.lock. The only change is dash-core-proof's version, 5.0.0-rc.4 → 5.0.1.

How Has This Been Tested?

cargo metadata --locked fails on v5.1-dev 20b5e06 and passes on this branch.

Breaking Changes

None.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed
  • If I added or changed GroveDB structure, I described it in the area's structure.rs, regenerated grovedb-structure.json, and checked the structure viewer link posted on this pull request

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

🤖 Generated with Claude Code

PR Hygiene · eed4901

  • Bots — thepastaclaw not yet — /skip-bots proceeds without the ones not yet reported
  • Self-review — post /self-reviewed
  • Reviewer requests paused — your 5 review slots are occupied; this PR is excluded from reviewers' queues. Required approvals still count without a slot.
  • Build running
  • Approvals
    • files with no dedicated owner (Cargo.lock) — QuantumExplorer or shumkov

When every merge requirement is met, the PR Hygiene check passes. Reviewer limits do not block merging; other required GitHub checks and protections still apply.

#5521 added dash-core-proof to the lockfile at 5.0.0-rc.4. It was tested
against a v5.1-dev from before the 5.0.1 bump (#5606) came in through the
v5.0-dev merge, so the crate's workspace version is now 5.0.1 and
`cargo --locked` refuses the stale entry. Every Rust workspace test job on
v5.1-dev fails before Clippy runs.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 29, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters: 1
  • Cargo.lock is excluded by !**/*.lock

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

Run configuration

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added this to the v5.1.0 milestone Oct 29, 2026

@PastaPastaPasta PastaPastaPasta left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved; only a cargo.lock change

@github-actions

github-actions Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Waiting for bot review — thepastaclaw not yet. Wait for the missing reviews, or a writer can post /skip-bots to proceed without them; blocking findings still need addressing.
Full checklist in the description.

@github-actions github-actions Bot added the waiting-bots Waiting for the review bots to report on this head label Oct 29, 2026
@thepastaclaw

thepastaclaw commented Oct 29, 2026 •

Copy link
Copy Markdown
Collaborator

🔍 Review in progress — actively reviewing now (commit eed4901) · triage: trivial
█████░░░░░░░░░░░░░░░ 26% · about 10 min left · running for 2 min
✅ triage → ⏳ Phase 1 (0/2 lanes) → ▫️ verify 1 → ▫️ gate → ▫️ publish
Estimated from recent reviews of this tier · updated 05:01 UTC · live progress

@PastaPastaPasta
PastaPastaPasta merged commit a317e4d into v5.1-dev Oct 29, 2026
22 of 23 checks passed
@PastaPastaPasta
PastaPastaPasta deleted the fix/cargo-lock-dash-core-proof-version branch October 29, 2026 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

waiting-bots Waiting for the review bots to report on this head

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants