[romchornyi]

Issue being fixed or feature implemented

v5.1-dev no longer compiles dash-sdk's lib tests. #5460 added a trailing platform_version parameter to broadcast_with_retries, and #5562, merged just before it, added broadcast/address_nonce_tests.rs, whose two calls still use the old signature. Neither PR conflicted textually, so both went green on their own heads. Every pull request on v5.1-dev now fails Rust workspace tests with E0061: this method takes 5 arguments but 4 arguments were supplied (e.g. https://github.com/dashpay/platform/actions/runs/40881914256).

What was done?

The two calls in address_nonce_tests.rs pass the platform version: the test's existing PlatformVersion::latest() binding in the first, PlatformVersion::latest() in the second, as the other broadcast_with_retries tests do. Test-only; the rest of the diff is rustfmt rewrapping the first call.

How Has This Been Tested?

• cargo test -p dash-sdk --lib: 529 passed.
• cargo clippy -p dash-sdk --all-targets: clean.

Breaking Changes

None.

Checklist:

• I have performed a self-review of my own code
• My Rust, FFI, WASM, Swift or Kotlin changes follow the coding conventions
• I have commented my code, particularly in hard-to-understand areas
• I have added or updated relevant unit/integration/functional/e2e tests
• I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
• I have made corresponding changes to the documentation if needed
• If I added or changed GroveDB structure, I described it in the area's structure.rs, regenerated grovedb-structure.json, and checked the structure viewer link posted on this pull request
• If I added or changed a system contract's document schemas, I checked the contract viewer link posted on this pull request

For repository code-owners and collaborators only

• I have assigned this pull request to a milestone

🤖 Generated with Claude Code

PR Hygiene · cc3078b

• Bots — thepastaclaw ✓
• Self-review — posted; again after any push
• Build green
• Approvals
  • rust-sdk (packages/rs-sdk/src/platform/transition/broadcast/address_nonce_tests.rs) — approved by lklimek

When every merge requirement is met, the PR Hygiene check passes. Reviewer limits do not block merging; other required GitHub checks and protections still apply.

Summary by CodeRabbit

• Tests
  • Updated broadcast retry and nonce-rejection test scenarios to include platform version information. These changes keep the tests aligned with the current interface; they do not change end-user behavior.

[coderabbitai]

No actionable comments were generated in the recent review.

Recent review info

Run configuration

• Source mode: Auto
• Repository: dashpay/platform
• Branch: fix/sdk-address-nonce-tests-platform-version
• File: .coderabbit.yaml
• Commit: cc3078b
• Layers: Repository YAML
• Review profile: CHILL
• Plan: Advanced
• Run ID: 98af2778-f80c-4405-88b5-d0b676d35595

Commits

Reviewing files that changed from the base of the PR and between 6323a43 and cc3078b.

Files selected for processing: 1

• packages/rs-sdk/src/platform/transition/broadcast/address_nonce_tests.rs

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Walkthrough

Two address-nonce tests now pass a platform version to broadcast_with_retries. Their mocked rejection and retry behavior remains unchanged.

Changes: Address-nonce test updates

Layer / File(s)	Summary
Update retry test calls packages/rs-sdk/src/platform/transition/broadcast/address_nonce_tests.rs	The sequential retry test passes its existing platform_version. The terminal nonce-rejection test passes PlatformVersion::latest().

Priority: Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

Possibly related PRs

• dashpay/platform#5511: Changes the SDK broadcast retry path exercised by these tests.
• dashpay/platform#5556: Changes broadcast_with_retries behavior and its retry observation path.
• dashpay/platform#5460: Adds a PlatformVersion argument to broadcast_with_retries and updates other callers and tests.

Suggested reviewers: claudius-maginificent

Merge Risk: Minimal · up to cc307

The focused test-call updates are consistent with the current API and introduce no actionable merge risk.

Pre-merge checks: 4 · 1

Failed checks: 1 warning

Check name	Status	Explanation	Resolution
Docstring Coverage		Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documenta…	Write docstrings for the functions missing them to satisfy the coverage threshold.

Passed checks: 4 passed

Check name	Status	Explanation
Description Check		Check skipped - CodeRabbit’s high-level summary is enabled.
Title check		The title names the fix (passing the platform version) and the area it touches (address nonce broadcast tests in the sdk). The raw summary confirms both broadcast_with_retries calls now pass a platfor…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Title check

Explanation

The title names the fix (passing the platform version) and the area it touches (address nonce broadcast tests in the sdk). The raw summary confirms both broadcast_with_retries calls now pass a platform version, which matches the title. The title is short, specific, and follows the conventional-commit style. It does not cover the PR's reference to the signature change in #5460, but that is a detail rather than the main change.

Full details: Docstring Coverage

Explanation

Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 2 functions across 1 files.

Resolution

Write docstrings for the functions missing them to satisfy the coverage threshold.

Finishing Touches: 💡 2

📝 Generate docstrings: 💡

• Commit to this branch
• Create a new PR

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

🛠️ Fix failing CI checks: 💡

• Commit to this branch
• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[github-actions]

Waiting for bot review — thepastaclaw not yet. Wait for the missing reviews, or a writer can post /skip-bots to proceed without them; blocking findings still need addressing.
Full checklist in the description.

[thepastaclaw]

✅ Final review complete — Phase 1 only — no blockers (commit cc3078b) · triage: trivial

[romchornyi]

/self-reviewed

[thepastaclaw]

Final review — Phase 1 only (trivial change)

The two stale broadcast_with_retries calls in address_nonce_tests.rs now pass the required PlatformVersion argument, matching the helper signature and all sibling call sites. The change is test-only and contains no correctness, layering, or consensus issues. Rust workspace and JavaScript test checks were still in progress at the captured CI snapshot; no failure related to this change was reported.

Review provenance

Source: reviewer 1: glm-5.3-flash (agent: phase1-reviewer, role: general); reviewer 2: glm-5.3-flash (agent: phase1-reviewer, role: architecture-layering); final verifier: gpt-6.1-sol (agent: sol-gate-verifier, role: final-verifier)

• Triage: trivial by gpt-6.1-sol (effort low) — This is a test-only signature update that passes an existing platform-version value to two calls, with no production behavior or critical-surface changes.
• Phase 1 reviewers: glm-5.3-flash — general (completed, effort high); agent phase1-reviewer, glm-5.3-flash — architecture-layering (completed, effort high); agent phase1-reviewer
• Phase 1 model: glm-5.3-flash — zai quota: 5h 100% left, weekly 91% left; passed over gemini-3.8-flash-high (antigravity quota lookup failed)
• Fresh verifier: gpt-6.1-sol — final-verifier; agent sol-gate-verifier
• Phase 2 reviewers: not run (triage rated this change trivial); this review comments and never approves

[github-actions]

Missing human approval. Automatic reviewer requests are paused and this PR is excluded from reviewers' queues. Merge, close, or draft another active PR by this author to free a review slot. Required human review can be satisfied without a slot; once all merge requirements are met, PR Hygiene passes.
Full checklist in the description.

[github-actions]

Policy satisfied — this can merge.
Full checklist in the description.