Skip to content

feat(dash-spv)!: check masternode list diffs against the block coinbase - #1077

Open
QuantumExplorer wants to merge 3 commits into
devfrom
feat/dash-spv-verify-mnlistdiff-coinbase
Open

QuantumExplorer wants to merge 3 commits into
devfrom
feat/dash-spv-verify-mnlistdiff-coinbase

test(dash): a refused diff leaves the engine as it was

daf4314
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 14, 2026 in 1s

77.78% (+0.24%) compared to f036951

View this Pull Request on Codecov

77.78% (+0.24%) compared to f036951

Details

Codecov Report

❌ Patch coverage is 98.22335% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.78%. Comparing base (f036951) to head (daf4314).
⚠️ Report is 55 commits behind head on dev.

Files with missing lines Patch % Lines
dash/src/network/message_sml.rs 96.05% 6 Missing ⚠️
dash/src/sml/masternode_list/merkle_roots.rs 98.50% 4 Missing ⚠️
dash/src/sml/masternode_list_engine/mod.rs 96.77% 3 Missing ⚠️
dash-spv/src/storage/masternode.rs 99.38% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1077      +/-   ##
==========================================
+ Coverage   77.54%   77.78%   +0.24%     
==========================================
  Files         316      316              
  Lines       81211    81865     +654     
==========================================
+ Hits        62973    63682     +709     
+ Misses      18238    18183      -55     
Files with missing lines Coverage Δ
dash-spv/src/storage/mod.rs 85.00% <ø> (ø)
dash-spv/src/sync/masternodes/sync_manager.rs 92.07% <100.00%> (+1.11%) ⬆️
dash/src/merkle_tree/block.rs 91.69% <100.00%> (+4.65%) ⬆️
dash/src/sml/error.rs 0.00% <ø> (ø)
dash/src/sml/masternode_list/apply_diff.rs 94.77% <100.00%> (-0.26%) ⬇️
dash/src/sml/masternode_list/builder.rs 84.21% <100.00%> (+7.28%) ⬆️
dash/src/sml/masternode_list/from_diff.rs 93.54% <100.00%> (-0.74%) ⬇️
dash/src/sml/masternode_list_engine/helpers.rs 99.18% <100.00%> (+0.01%) ⬆️
dash-spv/src/storage/masternode.rs 99.00% <99.38%> (-0.49%) ⬇️
dash/src/sml/masternode_list_engine/mod.rs 91.20% <96.77%> (+0.75%) ⬆️
... and 2 more

... and 9 files with indirect coverage changes