TST: skip tests that convert MPArray to NumPy array - #966
Merged
Conversation
lucascolley
approved these changes
Sep 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference issue
https://github.com/data-apis/array-api-extra/pull/963/files/2b92ac1821678dbc6317d338937c7f94fc9082bf#diff-c50543e3908e94354bdcf5dc26eca11c2889ac795f4bb43bff052c457994afd1
What does this implement/fix?
This skips tests that convert MPArray to NumPy array. They passed before because
np.asarray(my_mparray)produces an object array with a single element, and simple operations (e.g. arithmetic) will work just fine with this object array because it performs the operations on each element. But I don't think that should be relied on; really,as_numpy=Trueand similar should raise for MPArrays due to precision loss.AI Generation Disclosure
I added
__array__to MPArray and had GPT-6 runarray-api-extratests with this change. We found those three failures and I told it to apply the skips similarly to GPU backends but citing precision loss as the reason.