ENH: angle: add delegation - #968
Open
ushnah wants to merge 2 commits into
Open
Conversation
lucascolley
requested changes
Sep 7, 2026
lucascolley
left a comment
lucascolley
left a comment
Member
There was a problem hiding this comment.
thanks @ushnah ! Please see https://data-apis.org/array-api-extra/contributing.html#delegation for further steps we need to take here. Let me know if you have any questions
lucascolley
self-requested a review
September 9, 2026 01:51
lucascolley
reviewed
Sep 9, 2026
Comment on lines
+54
to
+57
| # Torch treats real negative zero as positive zero, unlike atan2(0, z). | ||
| if _compat.is_torch_namespace(xp) and xp.isdtype(z.dtype, "complex floating"): | ||
| result = xp.angle(z) | ||
| return result * 180 / xp.pi if deg else result |
Member
There was a problem hiding this comment.
interesting, this is something to report to data-apis/array-api#595... @NeilGirdhar any initial thoughts?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for
angletowards gh-100