Repository navigation
fix: reviewer reads json-layout item checks, image placeholders and titles from portals runs - #101
Merged
Merged
Conversation
json-layout marks its item guard x-checked with field '' (the item's own keys, not one property): the reviewer is told the item the path names holds these keys and values, checked by the server, instead of "the label of what path names". Validated with portals verifier-affichage int2/int3/int4 (json-layout portals-integration). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…nd still holds "no longer shown … call the tool again to see the current state" read as "I could not see it": in a portals simulation the agent told a person it had not seen a render it had described, and re-ran identical previews. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…he exchange is wrapped In portals' simulations about 8 of 45 titles (haiku on the dev bridge) were « Titre de la conversation : … », « Titre demandé : … », a preamble line « Titre sans citation ni point final, … : » taken as the title, or the model going on with the conversation. - cleanTitle drops the labels seen (not a title that merely starts with « Titre »), and skips a line ending with a colon - the exchange is wrapped in <conversation> tags and followed by the instruction Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three small fixes found and validated with the portals simulations (agents, mcp and json-layout run from local checkouts in the portals dev stack).
approval-review/operations.ts): json-layout 2.14.1 marks itsitemguardx-checkedwithfield: ''(the item's own keys). The reviewer is now told "the item the path names holds these keys and values, checked by the server" instead of "the label of what path names". With json-layout's add answer handing the guard back, the needless cards on writes into a just-added block disappeared:verifier-affichagehad 3 inlab-r1and none over the following 9 runs.model-images.ts): an older screenshot's placeholder said "call the tool again to see the current state"; the agent read it as "I could not see it" and told a person so, and re-ran identical previews. It now says the image was seen and still holds.conversations/operations.ts): about 8 of 45 titles in the runs were « Titre de la conversation : … », « Titre demandé : … », a preamble line ending with « : », or the model going on with the conversation.cleanTitledrops those labels (not a title that merely starts with « Titre ») and skips a line ending with a colon; the exchange is wrapped in<conversation>tags with the instruction after it.Why: friction the portals simulations showed the person (false approval cards, « je n'ai pas pu revoir l'image », titles that are the instruction itself).
Regression risks:
undefined) instead of that line: check the UI's fallback for an untitled conversation.checkedTexttreats anx-checkedmarker whosefieldhas no segment (''or/) as an item guard: a server meaning "the whole value is the label" would now be described as an item check (openapi-mcp's labels always give a pointer such as/title).