Skip to content

fix: reviewer reads json-layout item checks, image placeholders and titles from portals runs - #101

Merged
albanm merged 3 commits into
mainfrom
portals-integration
Nov 13, 2026
Merged

albanm merged 3 commits into
mainfrom
portals-integration

Conversation

@albanm

@albanm albanm commented Nov 13, 2026

Copy link
Copy Markdown
Member

Three small fixes found and validated with the portals simulations (agents, mcp and json-layout run from local checkouts in the portals dev stack).

  • Reviewer (approval-review/operations.ts): json-layout 2.14.1 marks its item guard x-checked with field: '' (the item's own keys). The reviewer is now told "the item the path names holds these keys and values, checked by the server" instead of "the label of what path names". With json-layout's add answer handing the guard back, the needless cards on writes into a just-added block disappeared: verifier-affichage had 3 in lab-r1 and none over the following 9 runs.
  • Image placeholder (model-images.ts): an older screenshot's placeholder said "call the tool again to see the current state"; the agent read it as "I could not see it" and told a person so, and re-ran identical previews. It now says the image was seen and still holds.
  • Conversation titles (conversations/operations.ts): about 8 of 45 titles in the runs were « Titre de la conversation : … », « Titre demandé : … », a preamble line ending with « : », or the model going on with the conversation. cleanTitle drops those labels (not a title that merely starts with « Titre ») and skips a line ending with a colon; the exchange is wrapped in <conversation> tags with the instruction after it.

Why: friction the portals simulations showed the person (false approval cards, « je n'ai pas pu revoir l'image », titles that are the instruction itself).

Regression risks:

  • A title answer made only of a line ending with « : » now gives no title (undefined) instead of that line: check the UI's fallback for an untitled conversation.
  • The placeholder text changed: conversations running at deploy miss the provider's prompt cache once, on the part after their first replaced image.
  • checkedText treats an x-checked marker whose field has no segment ('' or /) as an item guard: a server meaning "the whole value is the label" would now be described as an item check (openapi-mcp's labels always give a pointer such as /title).
  • The reviewer change only matters with json-layout core ≥ 2.14.1 in the mcp image; with 2.14.0 nothing is marked and behaviour is unchanged.

albanm and others added 3 commits November 13, 2026 12:07
json-layout marks its item guard x-checked with field '' (the item's own keys, not one property):
the reviewer is told the item the path names holds these keys and values, checked by the server,
instead of "the label of what path names".

Validated with portals verifier-affichage int2/int3/int4 (json-layout portals-integration).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…nd still holds

"no longer shown … call the tool again to see the current state" read as "I could not see it":
in a portals simulation the agent told a person it had not seen a render it had described, and
re-ran identical previews.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…he exchange is wrapped

In portals' simulations about 8 of 45 titles (haiku on the dev bridge) were « Titre de la
conversation : … », « Titre demandé : … », a preamble line « Titre sans citation ni point
final, … : » taken as the title, or the model going on with the conversation.
- cleanTitle drops the labels seen (not a title that merely starts with « Titre »), and skips a
  line ending with a colon
- the exchange is wrapped in <conversation> tags and followed by the instruction

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions github-actions Bot added the fix label Nov 13, 2026
@albanm
albanm merged commit 3b48773 into main Nov 13, 2026
4 checks passed
@albanm
albanm deleted the portals-integration branch November 13, 2026 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant