Repository navigation
fix(i18n): english base for the site schema, translated server messages and proofread texts - #197
Merged
Merged
Conversation
- admin users: the identity provider sync notice reuses pages.organization.fromCache instead of a hard-coded French sentence - admin site: the OIDC and SAML help slots use new pages.admin.site.oidcHelp, samlHelp and samlHelpLink keys (the SAML link goes through <i18n-t>) - me: "unlimited" max created organizations uses a new common.unlimited key - new keys are written in the 6 languages (fr, en, de, es, it, pt) - pass the session locale to toLocaleString in delete-department-menu and admin organizations - site schema: add x-i18n-title to the 4 titles that had none (OIDC color, credentials encoding mode, authorization method, body format) and x-i18n-description to the credentials encoding mode, following the schema's existing pattern (French base, override in the 6 languages) - index.html: static lang="en" (App.vue sets it from the session via useHead)
- site schema and the patch-req-body layout: the English text moves to the base title / description / label / help / messages keywords (111 fields), the French one stays in x-i18n-*.fr with de, es, it, pt; the redundant en entries are dropped - the root title keeps en: 'Site', the post / patch body schemas append a suffix to the base title to name their types - generated type names of the site schema follow the English titles; the imported ones ($defs names, Site, OpenIDConnect, SitePost, SitePatch) are unchanged - ui: fallbackLocale 'en' on createI18n
createI18n gets legacy: false, like the other services: vue-i18n 11 started in its deprecated legacy mode, with a console warning. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Messages (fr, en): - fr: missing commas after introductory clauses, "à 2 facteurs", "le mode admin", "a expiré", "non prise en charge", "bibliothèque", "connexion" instead of "login", "en lecture seule", "fournisseur d'identité", "code de récupération", typography of ":" - fr: the SAML help reads "..., puis donnez-lui ce lien en retour" - en: typos (approriate, apparence, mote, anly, attemps, Passordless, browers, Ths), "log in" as a verb, no space before "?" and ":", "terms of service", "mailbox", articles, comma splices and clumsy sentences of the doc, errors and mails - labels shown at the start of a field, button or table cell get sentence case - deleteDepartmentHasMembers, partnersQuotaPending and nhiConnectionsCount use vue-i18n plural forms in every locale instead of "(s)"; de had a portuguese text - me.vue: the ":" after the maximum number of organizations moves into a new maxCreatedOrgsValue message, nbCreatedOrgs loses its space before ":" in en and de Site schema: - fr: "sur un autre de vos sites", "Valeurs de l'attribut", "département", "Contrôlez", "lui-même", "Métadonnées XML", "identifiants" instead of "crédentiels", "en-tête", "obsolète", "mot de passe", "inclut", "URI", commas - en: "Warning: the configuration must...", clearer userInfoSource and redirect labels, "User management" - option labels in sentence case in every locale Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The key lacked its pages.login. prefix: the downloaded file started with the raw key. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- user-facing errors that were hardcoded in French go through the request language: partner invitations, the members quota of invitations, the contact form (spam and rate limit answers), the core identity provider conflict - errors thrown where the request is not at hand (OAuth providers, mongo storage, account main site resolution, SSO member role and department) use a new I18nHttpError, translated by i18nErrorMiddleware before the error handler; its own message is the English text - the intro of the forwarded contact mail follows the request language - pure logs and internal errors (keepalive answers, session token checks, LDAP DN building, missing email from the provider) are in English - the boot logs report color and main site warnings in English - new keys in the 6 languages: errors.conflict2FA (used by the 2FA router but declared nowhere), oauthNoEmail, oauthEmailNotVerified, githubNoVerifiedEmail, facebookDisabled, partnerInvitationMismatch, partnerConflict, noPendingPartnerInvitation, memberOfParentOrg, memberOfDepartment, departmentUnknown, unknownOrgRole, missingDepartmentAttribute, otherCoreIdProvider, authOnlyOtherSiteChain, spamSuspected, rateLimitMessages and mails.contact.intro - de, es, it and pt get the keys only fr and en had (mainSite.ignoredField, mainSite.ignoredCategory, pages.admin.site.mainSiteExplanation, pages.admin.sites.mainSite), so getMessage no longer falls back to French
UI:
- the app bar contact button uses pages.contact.title instead of a
hardcoded "Nous contacter"
- admin organizations reuse pages.organization.fromCache with its
{fromNow} placeholder; pages.admin.organizations.fromCache is removed
- nbCreatedOrgs takes a {count} placeholder instead of a concatenation
- createdOrgsLimit, pages.admin.organizations.members and
passwordLists.subtitle use plural forms with the count passed to t()
- v-t on the partner invitation buttons becomes :text="$t()"
- "Creation not finalized" shown after a member or partner is put in
parentheses
Messages:
- fr: "Attention : les données", missing commas, RSA "signature" keys,
account creation mail caption, "adresse email" everywhere (dominant
form), "portées" for OAuth scopes, French quotes, "deux fois",
"à 2 facteurs" everywhere, deleteMyself without a dangling {name}
- en: "Log in" everywhere, missing commas, comma splices, "login request"
instead of "identification request" in mails, account creation mail
caption, noCreation mail "or has not been validated", plannedDeletion
caption aligned with fr, a few clearer labels
- es, it, pt, de: sentence case already applied in fr and en (active,
inactive, reject, tooLong, emailConfirmed, emailNotConfirmed,
downloadCsv, no, yes, rememberMe, recovery2FACode, recovery2FADownload,
createOrg, newOrgName, confirmMigration, deleteMyselfCheck), de
rememberMe "Angemeldet bleiben", drop2FATitle with the {name} the UI
passes, two broken de mail captions
- de: "Wenn die E-Mail-Adresse...", "Abteilung" instead of "Abteilungsmitglied", "keiner bekannten Rolle", "zum Abrufen", infinitive labels instead of imperatives, "E-Mail-Adresse", "Header", "Kennung", "oberste Ebene der Organisation" - es, it, pt: translated "XML metadata", "Atención:" style warnings, articles in labels, "Correo electrónico completo", Brazilian pt (usuário, registro, logout, Logotipo) - it: "dell'id_token", "dell'access_token", "e-mail non verificate", "e-mail" everywhere - discovery description example uses my-provider in every non-French locale - fr: "portées" for the OAuth scopes of providers and site clients
- the error redirected to the login page is in the request language, not the English message of I18nHttpError
…ages - untranslated english and french values translated, wrong words and machine translation nonsense rewritten, mails reworked - one register per language (Sie, usted, Lei, você), one term per concept - portuguese aligned on pt-BR, like the site schema - literal config values back to their literal form in the doc texts - the sentence about an account created automatically, absent from en and fr, removed from the invitation mails - keys, placeholders, plural forms and html tags identical to en
unhead only set the lang attribute of the document and the title of the login page: a one line watchEffect sets the lang, like the other services, and the login page sets document.title and restores the previous title when it unmounts. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
….5.4 The lib releases of the fr/en pass: dates in the session language for non French locales, English byte units, English schema bases, translated search-address and date-match-filter. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…s 1.28.1 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ddleware - api test: patching a member to an unknown department answers Département inconnu. without Accept-Language, Unknown department. in en and Unbekannte Abteilung. in de (it fails without the middleware) - oauth and saml callbacks: the comment no longer says the English message is logged, returnError logs the translated one
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the FR/EN issues found by the platform-wide i18n audit, move the site schema to an English base, and proofread the messages in all 6 languages.
api/types/site/schema.js,api/doc/sites/patch-req-body): English base texts, fr/de/es/it/pt kept inx-i18n-*, redundantenentries dropped. Generated type names follow the English titles; the imported types (Site,SitePost,SitePatch,OpenIDConnect,$defs) keep their names.I18nHttpErrorcarries a message key, translated byi18nErrorMiddleware(and on the login page after an OAuth/SAML callback). Pure logs and internal errors are in English.<i18n>keys, plural forms instead of "(s)", session locale fortoLocaleString(), vue-i18n in composition mode withfallbackLocale: 'en', staticlang="en"inindex.htmlreplaced by the session language through awatchEffect(unhead removed: it only set that attribute and the login page title, nowdocument.titlerestored on unmount), fixed title of the downloaded 2FA recovery codes.Why: consistent English/French (and other locales) across the platform, as part of the i18n audit.
Heads-up: