aitools: register Claude's official marketplace before install - #6485
Open
rclarey wants to merge 1 commit into
Open
aitools: register Claude's official marketplace before install#6485rclarey wants to merge 1 commit into
rclarey wants to merge 1 commit into
Conversation
Claude's databricks plugin lives in the claude-plugins-official marketplace, which is not reliably registered locally. The installer treated it as a built-in marketplace (empty Source) that must never be added, so the pre-install `plugin marketplace update` had nothing to refresh and the install failed with "not found in marketplace". Split the two things an empty Source used to conflate: Source now only names the repo to `marketplace add`, and a new Shared flag marks a marketplace we don't own. Claude gets a real Source so the marketplace is added before the update+install, plus Shared=true so uninstall never de-registers the shared marketplace. The uninstall message is updated to match (it no longer claims to remove a Shared marketplace). Co-authored-by: Isaac <no-reply@databricks.com>
parthban-db
approved these changes
Sep 4, 2026
parthban-db
left a comment
parthban-db
left a comment
Contributor
There was a problem hiding this comment.
LGTM modulo comments.
Comment on lines
+148
to
+151
| // claudeOfficialMarketplace is Claude Code's official marketplace, where the | ||
| // databricks plugin is published. It is not reliably registered locally, so the | ||
| // CLI adds it (from claudeOfficialMarketplaceSrc) before refreshing and | ||
| // installing, but never de-registers it since it is shared, not ours. |
Contributor
There was a problem hiding this comment.
Can we keep this concise and include the source URL? The repo rule asks
external-tool behavior to link its source, while the install details are clear
from claudePlugin below. Ditto for the same details repeated on Shared and in
the installer.
Suggested change
| // claudeOfficialMarketplace is Claude Code's official marketplace, where the | |
| // databricks plugin is published. It is not reliably registered locally, so the | |
| // CLI adds it (from claudeOfficialMarketplaceSrc) before refreshing and | |
| // installing, but never de-registers it since it is shared, not ours. | |
| // Source: https://github.com/anthropics/claude-plugins-official. |
| Marketplace: claudeOfficialMarketplace, | ||
| ID: databricksPluginID, | ||
| Source: "", | ||
| Source: claudeOfficialMarketplaceSrc, |
Contributor
There was a problem hiding this comment.
Can you add a .nextchanges/cli/ entry for this? This fixes a user-visible
aitools install failure, so the repository's changelog rule applies.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
No longer treat
claude-plugins-officialmarketplace as built-in and manually install it before installing thedatabricksplugin.This PR splits the two things an empty Source used to conflate: Source now only names the repo to
marketplace add, and a new Shared flag marks a marketplace we don't own. Claude gets a real Source so the marketplace is added before the update+install, plus Shared=true so uninstall never de-registers the shared marketplace. The uninstall message is updated to match (it no longer claims to remove a Shared marketplace).Why
The
claude-plugins-officialmarketplace was not reliably registered locally (e.g. whenucode claudefirst installs Claude). The installer treated it as a built-in marketplace (empty Source) that must never be added, so the pre-installplugin marketplace updatehad nothing to refresh and thedatabricksplugin install failed with "not found in marketplace".Tests
updated unit tests + manually verified via
ucode claude(reliable repro)