fixed pipeline for UNDATA - #2239
Open
niveditasing wants to merge 3 commits into
Open
niveditasing wants to merge 3 commits into
niveditasing wants to merge 3 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds resolved places for Kyrgyzstan and Uganda, registers a validation configuration file in the manifest, and defines validation rules for deleted records and date freshness. The review feedback suggests improving the date freshness SQL query by extracting the year portion of MaxDate before casting it to an integer, ensuring robustness against ISO 8601 date formats.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Fixes the UNData auto-refresh failure caused by upstream city renaming in UN Table 240 that triggered
check_deleted_records_percentfailure.Changes
UNData_places_resolved_csv.csv):Manas (Jalal-Abad) Kyrgyzstan->wikidataId/Q487689Gulu City Uganda->wikidataId/Q581379Hoima City Uganda->wikidataId/Q1624192Masaka City Uganda->wikidataId/Q1032233Mbarara City Uganda->wikidataId/Q731039(Reduces deleted observations in
nodes-deleted.mcffrom 25 to 0)validation_config.json):check_deleted_records_percentthreshold to0.1%.check_max_date_freshnessusingSQL_VALIDATORto enforce date freshness.manifest.json):"validation_config_file": "validation_config.json".