Repository navigation
feat(api): rename response total to total_records - #31
Merged
Merged
Conversation
The row count returned by datastore_search, datastore_search_sql, datastore_create and datastore_upsert is now `result.total_records`, and datastore_info reports it as `meta.total_records`. The `include_total` request flag is unchanged. Refs datopian/neso-nextgen-shared#205
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renames the row-count key in datastore responses, per datopian/neso-nextgen-shared#205.
datastore_search/datastore_search_sql:result.total→result.total_recordsdatastore_create/datastore_upsert:result.total→result.total_records(still only withinclude_total=true)datastore_info:result.meta.total→result.meta.total_recordsThe
include_totalrequest flag is unchanged. Internal engine/service names staytotal; only the wire key changes. This is a breaking change for clients readingtotal.Docs (
API.md,CLAUDE.md) and tests updated;pytestpasses (538).