Problem with msdos86 and msdos386 targets #365

Activity

1. johnsonjh commented on Jul 15, 2026

   

   johnsonjh

   on Jul 15, 2026

   ContributorAuthor

   More actions

   It looks like "rb" is broken:

   • test.c:

     #include <stdio.h>
     
     int main(void)
     {
       FILE * fp1 = fopen ("test.c", "r");
       FILE * fp2 = fopen ("test.c", "rb");
     
       printf (" r=%d\n", fgetc (fp1));
       printf ("rb=%d\n", fgetc (fp2));
     
       return 0;
     }

   • Result:

     $ /opt/ack/bin/ack -mmsdos86 -O3 test.c -o test.com
     $ emu2 test.com
      r=35
     rb=-1
2. johnsonjh commented on Jul 15, 2026

   

   johnsonjh

   on Jul 15, 2026

   ContributorAuthor

   More actions

   @davidgiven I fixed it - PR coming.
3. johnsonjh commented on Jul 15, 2026

   

   johnsonjh

   on Jul 15, 2026

   ContributorAuthor

   More actions

   @davidgiven #366 fixes the problem - binary mode file I/O was broken, it was always returning EOF and never what was read.
4. davidgiven

   added a commit that references this issue on Jul 15, 2026

   Fix DOS binary file I/O always returning EOF

   ...

   This issue will close once commit 40b60ac is merged into the 'default' branch.

   40b60ac
5. davidgiven

   closed this as completedin #366on Jul 15, 2026