-
Notifications
You must be signed in to change notification settings - Fork 612
Fix COPY to STDOUT/from STDIN leaving the connection stuck #1636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
anandghegde
wants to merge
2
commits into
dbcli:main
Choose a base branch
from
anandghegde:fix-copy-stdout-transaction
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+92
−1
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can
psycopg.ProgrammingErrorbe raised in situations other thancopy, and if so, how do we handle that?Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, and those pass through unchanged. psycopg raises
ProgrammingErrorin two broad cases here:SyntaxErrorandUndefinedTable. By the time these are raised the server has already ended the statement, so the transaction status isIDLEorINERROR, neverACTIVE.execute_normal_sqlpasses no parameters, and these are raised before anything is sent, so the status is notACTIVEeither.The only result that leaves the connection
ACTIVEis aCOPY_IN/COPY_OUTstatus (_raise_for_resultin psycopg's_cursor_base.py). That is why the handler checkstransaction_statusrather than the message, and re-raises the original exception otherwise.To pin this down I added
test_other_programming_errors_are_not_rewrittenin ec70d50: a syntax error and an undefined table still raise their own exception classes without the\copymessage, and the connection stays usable. With theACTIVEcheck removed, both cases fail. The full suite passes against Postgres 16 (2785 passed).