Repository navigation
Conversation
Owner
|
Thank you for this fix, and apologies for the very delayed response. You correctly identified the problem: Both issues have now been addressed in #2 through a shared form-encoding helper, with regression tests verifying the transmitted values for check creation and updates. These changes are available in version 0.1.0, now published on PyPI: https://pypi.org/project/updownio/0.1.0/ I'm closing this PR without merging because the current implementation already covers the fix. Your contribution was valid and is appreciated—thank you for taking the time to report and correct it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed for work properly: disabled_locations and recipients