Repository navigation
fix(map): cargo tree's output is read uncolored - #1052
Merged
Merged
Conversation
CI sets CARGO_TERM_COLOR=always, so cargo tree wrapped its `(*)` repeat marker in terminal escape codes and the feature reader refused the line (Code map job on #1051). Every cargo tree the map runs now asks for `--color never`, and a line holding escape codes is refused by name, saying so. Reproduced locally with CARGO_TERM_COLOR=always (314 colored lines); with --color never the output is byte-identical to the uncolored run, and the full map builds with unchanged readings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The Code map job fails on
mainsince #1051. CI setsCARGO_TERM_COLOR=always, socargo treewraps its(*)repeat marker in ANSI escape codes, and the map's feature reader refuses those lines:The fix has two parts:
cargo treecall inmake requirement-mapnow passes--color never, so its input is plain whatever the environment sets.Verification
CARGO_TERM_COLOR=always: 314 lines came out coloured.--color neverunder the same setting, the output is byte-identical to a plain run.CARGO_TERM_COLOR=always make requirement-mapbuilds, with 0 escape codes in the feature files. The readings are unchanged:cargo test -p requirement_map --release: the cfgs tests pass, 9 of 9, including one for coloured input.-D warnings,make lintand the real-code guard all pass.