Declare installGoTools option to toggle tools installation - #1729
Open
Sven Giermann (Giermann) wants to merge 3 commits into
Open
Declare installGoTools option to toggle tools installation#1729Sven Giermann (Giermann) wants to merge 3 commits into
Sven Giermann (Giermann) wants to merge 3 commits into
Conversation
Added 'installGoTools' option to specify installation of common Go tools.
Added 'installGoTools' option to README for Go tools installation.
Author
|
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tools-installation block on (controlled by variable
INSTALL_GO_TOOLS) should by a user-facing toggle.Prior to this patch
INSTALL_GO_TOOLShad to be put into devcontainer.json and was not documented.This adds the missing option declaration and fixes install.sh to read the correctly-exported name, consistent with the version and golangCiLintVersion pattern immediately above it.