Skip to content

fix(hub): retry temp-dir cleanup on Windows to avoid EPERM #408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
antfu merged 1 commit into from
Sep 25, 2026
+3 −1
Merged

fix(hub): retry temp-dir cleanup on Windows to avoid EPERM #408

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/hub/src/node/__tests__/host-terminals.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -430,7 +430,9 @@ describe.runIf(process.platform === 'win32')('devframeTerminalHost child-process
}, 10_000)
// The host holds the `cmd.exe` wrapper, not the node child.
expect(session.getChildProcess()?.pid).not.toBe(pid)
return { session, pid, cleanup: () => rmSync(dir, { recursive: true, force: true }) }
// Windows releases the killed process's file handles asynchronously, so an
// immediate `rm` can still hit EPERM; retry until the handles are gone.
return { session, pid, cleanup: () => rmSync(dir, { recursive: true, force: true, maxRetries: 10, retryDelay: 100 }) }
}

it('terminate() kills the process started by a .cmd shim', async () => {
Expand Down
Loading