fix(hub): keep shim dir off the child cwd so Windows cleanup can rmdir - #409
Merged
Merged
Conversation
◈ PR LensNote Only tests changed, so PR Lens left this pull request undrawn. Comment
|
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Follow-up to #408. The retry added there downgraded the Windows unit-test failure from
EPERMtoEBUSYbut did not fix it:EBUSYon thermdirsyscall for the temp dir itself (not a file inside it) means a process in the tree still holds that directory as its current working directory. The shim session spawns the child withcwd: dir, so Windows keepsdirlocked, and no amount of retrying clears a held cwd.What
The
.cmdshim resolveschild.cjsthrough%~dp0(an absolute path), so the child needs no cwd of its own. Spawn it from the parent temp dir (tmpdir()) instead of the shim's own dir, so nothing holds the dir open and the laterrmdirsucceeds. The existing retry still covers transient file-handle release for the files inside.Test-only change; no runtime behaviour changes.
This PR was created with the help of an agent.