Skip to content

nested: indirect-consumer fixture proves gated toolchains do not register (part of #12601) - #12688

Draft
TrapsterDK wants to merge 4 commits into
mainfrom
indirect-consumer-gate
Draft

TrapsterDK wants to merge 4 commits into
mainfrom
indirect-consumer-gate

Conversation

@TrapsterDK

@TrapsterDK TrapsterDK commented Nov 14, 2026 •

Copy link
Copy Markdown
Collaborator

Adds a case to nested_bazel_harness_test: the root depends on a module mid that depends on rules_dx, with no dx bazelrc. It resolves toolchains for the cc and jdk runtime types and asserts no rules_dx toolchain is selected, and that one is selected with --@rules_dx//config:toolchains=true.

  • The case records under its own indirect lock; nested_cache_update --from merges every recorded lock stem, and harness_locks globs the locks.
  • The indirect consumer pins the patched rules_flutter as dx init does.
  • //:module_srcs gains the extension inputs a consumer resolves: fortran/private, patches/{elvis,rules_fortran,rules_ocaml}, ocaml *.BUILD.bazel, php pcov files, python/pins.json, and the toolchain platform packages of ocaml, kotlin, gcc and swift.

Part of #12601.

Evidence (linux_x86_64, --config=nested_record): 43557665207 (rules_flutter 3.47.9 missing, fixed), 43557878601 (ocaml platform packages missing, fixed), 43558258550 failed: rules_py++host_platform+rules_py_uv_host: "Unable to determine host libc!", reached through @@rules_dx++python+dx_python_toolchains//:libc_glibc. Pending: a fix for that host libc probe, then a green record run and nested_cache_update --from with the existing tools/testing/nested_cache and the record artifact.

Tested locally: //tools/testing:module_srcs_test, //tools/testing:module_extension_srcs_test, //tools/testing:nested_cache_update_test pass; //tools/testing:nested_bazel_harness_test builds.

🤖 Generated with Claude Code

https://claude.ai/code/session_01Xut2hws3L7Tg4oUvpSvuYD

@TrapsterDK

Copy link
Copy Markdown
Collaborator Author

Evidence run 43555264455 (linux_x86_64, nested harness test) failed: the new indirect-consumer case needs the harness cache set re-recorded (platforms-1.1.0 archive) and, once toolchain resolution runs, every package, pin and patch file that rules_dx registers toolchains and extensions from in the nested rules_dx copy (module_srcs). The record run of the case must also execute its cquery calls. Stays draft.

TrapsterDK and others added 2 commits November 14, 2026 05:33
…ster (part of #12601)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Xut2hws3L7Tg4oUvpSvuYD
…ension inputs in module_srcs (part of #12601)

The indirect-consumer case runs in record mode and keeps an indirect lock.
nested_cache_update --from merges every recorded lock stem. module_srcs
carries the patches, BUILD files and pins the fortran, ocaml, php, erlang
and python extensions read.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Xut2hws3L7Tg4oUvpSvuYD
@TrapsterDK
TrapsterDK force-pushed the indirect-consumer-gate branch from 379dbcd to 13ff547 Compare November 14, 2026 04:38
TrapsterDK and others added 2 commits November 14, 2026 05:41
…init (part of #12601)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Xut2hws3L7Tg4oUvpSvuYD
…r resolves (part of #12601)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Xut2hws3L7Tg4oUvpSvuYD
@TrapsterDK TrapsterDK added the needs-review Touches review paths; needs a second-session Review: comment label Nov 14, 2026
@TrapsterDK

Copy link
Copy Markdown
Collaborator Author

Record runs on linux_x86_64: 43557665207 and 43557878601 failed on fixed gaps; 43558258550 fails in rules_py's host libc probe (rules_py_uv_host: Unable to determine host libc!) reached via dx_python_toolchains//:libc_glibc. Evidence budget for this pass used; stays draft.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-review Touches review paths; needs a second-session Review: comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant