Repository navigation
deploy, apple ops: satisfy denied unsafe_code (part of #12395) - #12691
Open
TrapsterDK wants to merge 1 commit into
Open
TrapsterDK wants to merge 1 commit into
TrapsterDK wants to merge 1 commit into
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Xut2hws3L7Tg4oUvpSvuYD
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #12395. Depends on #12681 (base branch rust-deny-panic-unsafe).
Adds
#[expect(unsafe_code, reason)]on the items holding existing SAFETY-commented unsafe in deploy/private (config, test_support, install tests) and apple/private/tools/ops (lib, signing). The panic sites in these crates are inside test code, which is exempt.Not run: clippy (tools/dx check --affected hit a Bazel OOM and a generate failure unrelated to these files), nested-Bazel and consumer tests.
Remaining: unsafe in fixtures apple/tests/fixtures/{macos_bundle,swift_app,xcframework_share,shared_core} and deploy/tests/fixtures/consumer_archive/app.rs; clippy confirmation for any other site.