Skip to content

cli/test_scratch, gomod, audit, adopt, qt bridge: satisfy denied unsafe_code and panic (part of #12395) #12697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TrapsterDK wants to merge 1 commit into
base: rust-deny-panic-unsafe
Choose a base branch
from
+5 −1
Open

cli/test_scratch, gomod, audit, adopt, qt bridge: satisfy denied unsafe_code and panic (part of #12395) #12697

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion qt/private/rust/src/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,12 @@ struct Generated {
source: Vec<u8>,
}

#[expect(
unsafe_code,
reason = "std::env::set_var is unsafe; cxx-qt reads CLANG_FORMAT_BINARY in-process"
)]
fn main() -> ExitCode {
// SAFETY: the process is single-threaded here or the env lock is held.
// SAFETY: main has not spawned any thread yet, so nothing reads the environment concurrently.
unsafe { std::env::set_var("CLANG_FORMAT_BINARY", "") };
let args: Vec<String> = std::env::args().skip(1).collect();
match run(&args) {
Expand Down
Loading