Repository navigation
Conversation
punam20
force-pushed
the
fix_disable_cira_issue
branch
6 times, most recently
from
October 16, 2026 04:22
6ce44f5 to
307d2da
Compare
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Missing synchronization can cause profile-test failures and silently bypass the CIRA emptiness assertion.
3 open findings
What changed in this PR
Updates Cypress tests to accommodate Console deployments with CIRA disabled.
Changes:
- Exposes
DISABLE_CIRAto browser-side tests. - Skips CIRA-dependent profile cases and removes unconditional config waits.
- Makes the CIRA empty-server check conditional on navigation visibility.
| File | Description |
|---|---|
| cypress/support/public-config.ts | Exposes the CIRA disable flag. |
| cypress/e2e/integration/profile/delete.spec.ts | Filters CIRA profile deletions. |
| cypress/e2e/integration/profile/create.spec.ts | Filters CIRA profile creation cases. |
| cypress/e2e/integration/profile/create-error.spec.ts | Skips the CIRA-dependent invalid-name test. |
| cypress/e2e/integration/login/ensureEmpty.spec.ts | Conditionally checks for CIRA configs. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+24
to
+31
| cy.get('body').then(($body) => { | ||
| // Nav item is hidden entirely when the server reports CIRA disabled | ||
| // (APP_DISABLE_CIRA) - nothing to check against in that mode. | ||
| if ($body.find('a:contains("CIRA Configs")').length > 0) { | ||
| cy.goToPage('CIRA Configs') | ||
| cy.contains('No CIRA Configs').should('be.visible') | ||
| } | ||
| }) |
| @@ -47,12 +49,13 @@ describe('Test Profile Page', () => { | |||
| cy.wait('@get-profiles5') | |||
|
|
|||
| cy.get('button').contains('Add New').click() | |||
| @@ -50,27 +52,32 @@ describe('Test Profile Page', () => { | |||
| }).as('get-profiles2') | |||
|
|
|||
| cy.get('button').contains('Add New').click() | |||
Signed-off-by: punam biswal <punam.biswal@intel.com>
lim-chris
approved these changes
Oct 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
What are you changing?
Anything the reviewer should know when reviewing this PR?
If the there are associated PRs in other repositories, please link them here (i.e. device-management-toolkit/repo#365 )