ci: drop setup-node registry-url so OIDC publishing works - #179
Merged
Merged
Conversation
registry-url makes setup-node write `_authToken=${NODE_AUTH_TOKEN}` into
.npmrc. With no token set that resolves to an empty credential, so npm treats
auth as configured, skips the trusted-publishing OIDC exchange and PUTs
unauthenticated — which npm answers with 404. That is why 5.6.0-beta.1 and
beta.2 never published. npmjs.org is the default registry, so nothing else
changes.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
14 tasks
finalerock44
added a commit
that referenced
this pull request
Sep 18, 2026
5.6.0-beta.1 and beta.2 were tagged and released but never reached npm: publish-npm-beta failed with `E404 PUT /@devicecloud.dev%2fdcd` because setup-node's registry-url wrote an empty auth token, so npm never ran the OIDC exchange. #179 removed it; nothing releasable has landed since, so this empty commit forces a cut to prove the fix. Release-As: 5.6.0-beta.3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
registry-url makes setup-node write
_authToken=${NODE_AUTH_TOKEN}into .npmrc. With no token set that resolves to an empty credential, so npm treats auth as configured, skips the trusted-publishing OIDC exchange and PUTs unauthenticated — which npm answers with 404. That is why 5.6.0-beta.1 and beta.2 never published. npmjs.org is the default registry, so nothing else changes.What & why
Type of change
fix— bug fixfeat— new featureperf— performance improvementrefactor— code change that's neither a fix nor a featuredocs— documentation onlychore/ci/build/test— tooling, no user-facing change!or PR notes aBREAKING CHANGE:)Checklist
pnpm lintpassespnpm typecheckpassespnpm buildpassesCHANGELOG.md(release-please handles this)README.md/STYLE_GUIDE.mdupdated if behaviour or output changedHow to test