ci: cut betas by hand and require a Release-As pin on promotions - #181
Merged
Merged
Conversation
Betas move from a second release-please track on `dev` to a dispatched `Release beta` workflow that derives the version from the npm registry, so a beta can no longer sort below `@latest` the way 5.0.0, 5.2.0 and 5.5.0 did. The beta config, manifest and npm-publish beta path go with it; CHANGELOG-beta is frozen at 5.6.0-beta.2. Stable is unchanged apart from a new back-merge PR after each release, and a `promotion-pin` CI check: a promotion is a merge, so every beta tag is reachable from production and release-please picks one as its base unless the stable version is pinned. That is what left production on 5.6.0-beta.1. Publishing now happens before the tag and GitHub release are created, so a failed publish no longer strands a release with no package on npm.
…ases # Conflicts: # .release-please-manifest-beta.json # CHANGELOG-beta.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Betas move from a second release-please track on
devto a dispatchedRelease betaworkflow that derives the version from the npm registry, so a beta can no longer sort below@latestthe way 5.0.0, 5.2.0 and 5.5.0 did. The beta config, manifest and npm-publish beta path go with it; CHANGELOG-beta is frozen at 5.6.0-beta.2.Stable is unchanged apart from a new back-merge PR after each release, and a
promotion-pinCI check: a promotion is a merge, so every beta tag is reachable from production and release-please picks one as its base unless the stable version is pinned. That is what left production on 5.6.0-beta.1.Publishing now happens before the tag and GitHub release are created, so a failed publish no longer strands a release with no package on npm.
What & why
Type of change
fix— bug fixfeat— new featureperf— performance improvementrefactor— code change that's neither a fix nor a featuredocs— documentation onlychore/ci/build/test— tooling, no user-facing change!or PR notes aBREAKING CHANGE:)Checklist
pnpm lintpassespnpm typecheckpassespnpm buildpassesCHANGELOG.md(release-please handles this)README.md/STYLE_GUIDE.mdupdated if behaviour or output changedHow to test