Skip to content

fix: honour the CLI exit code as the run verdict #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
finalerock44 merged 1 commit into from
Sep 15, 2026
Merged

fix: honour the CLI exit code as the run verdict #4

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 24 additions & 2 deletions src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,9 +147,17 @@ const run = async (): Promise<void> => {
let testOutput = '';
let uploadId: string | null = null;

// The CLI's exit code is the primary verdict: it is computed by the process
// that actually watched the run. 0 = every test passed, 1 = CLI/infra error,
// 2 = the run itself failed (a failed test, or a cancelled one). This used to
// be discarded for anything but 1, leaving the separate `dcd status` call as
// the only gate.
let cloudExitCode = 0;

try {
const { output, exitCode } = await executeCommand(cloudCommand);
testOutput = output;
cloudExitCode = exitCode;

if (exitCode === 1) {
throw new Error(
Expand Down Expand Up @@ -185,7 +193,18 @@ const run = async (): Promise<void> => {
}));
setOutput('flow_results', JSON.stringify(flowResults));

if (result.status === 'PASSED') {
// Fail on either signal. The exit code is authoritative for a run that
// finished badly; the status call can only add failures the CLI could not
// see. A non-terminal status (PENDING/RUNNING) alongside a clean exit is a
// racy or degraded status call, not a failure — the CLI watched the run to
// completion, so warn rather than fail the job.
if (cloudExitCode !== 0) {
console.error(
`Test run failed (dcd exited ${cloudExitCode}, status ${result.status}). ` +
`Check flow results: ${result.consoleUrl}`
);
process.exit(1);
} else if (result.status === 'PASSED') {
console.error('Successfully completed test run.');
process.exit(0);
} else if (result.status === 'FAILED' || result.status === 'CANCELLED') {
Expand All @@ -194,7 +213,10 @@ const run = async (): Promise<void> => {
);
process.exit(1);
} else {
console.error(`Test run finished with status: ${result.status}`);
console.error(
`dcd reported success but the upload status is ${result.status}. ` +
`Treating the run as passed: ${result.consoleUrl}`
);
process.exit(0);
}
} else {
Expand Down