fix(flow): don't split a flow with inline or conditional runFlow steps into a suite

[MxScripter]

Summary

A flow made only of runFlow steps, two or more of them with a file, is treated as a suite (IsSuite), and expandSuites runs each file as its own flow. That drops the flow's other runFlow steps without a word:

• inline blocks (when: + commands:) are skipped;
• a file runFlow's when: is ignored, so the file runs whatever the condition says.

Maestro has no suite expansion: it runs the file as written. We hit it with a reset flow of this shape:

appId: com.example.app
---
- runFlow: open_queues_tab.yaml
- runFlow: wait_for_queues_loaded.yaml
- runFlow:
    when:
      visible: "Clear location"
    commands:
      - tapOn: "Clear location"
- runFlow: open_more_menu.yaml
- runFlow:
    when:
      visible: "Sort By.*"
    commands:
      - tapOn:
          point: "15%,15%"

maestro-runner reported "Found 3 test flow(s)", ran only the three files, and passed. The location was never cleared and the menu was left open, so every test after it failed for an unrelated-looking reason ("Queues" not found: the open menu hides the tab bar).

Type of Change

• Bug fix (non-breaking change that fixes an issue)

Changes Made

• IsSuite returns false when a runFlow step is inline, has a when condition, or has an else branch. Such a step is part of the flow, so the flow runs as written.
• Flows made only of unconditional file runFlows are still suites, as before.
• Two TestFlow_IsSuite cases (two files plus an inline block; two files, one conditional); both fail on main.
• CHANGELOG entry under Unreleased / Fixed.

Related Issues

No existing issue or PR.

Testing

• go test ./pkg/flow/ ./pkg/executor/ pass; the new cases fail without the fix
• gofmt, go vet clean
• Tested manually on a real suite (Android emulator and iOS simulator, in parallel) where 10 flows have this shape, including the reset every test starts with. Before: Android 7 of the first 13 tests failed, iOS 9 of the first 15, mostly on "Queues" not found. After: Android 29 of 40 pass, iOS 20 of 34; the remaining failures are known app bugs the suite tracks, apart from one per platform still being looked at.

Additional Notes

Even a pure file-only "suite" differs from Maestro when run directly (separate flows, so output.* isn't shared and a failure doesn't stop the later files). That's left as is here; happy to discuss an opt-out if useful.

🤖 Generated with Claude Code

[omnarayan]

Thanks @MxScripter. A flow silently losing its inline and conditional steps is a nasty one to debug, especially when the failure shows up tests later as "Queues not found". Treating any inline, when: or else step as part of the flow is the right line. Plain lists of files are unchanged. Merged; part of the next release.

On your note about plain file-only suites differing from Maestro (output.* not shared, a failure not stopping later files): agreed, it's worth discussing. Please open an issue if it bites you, and we'll look at matching Maestro there.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!