Repository navigation
#2714: fix oc url-updater version regex to support multi-digit minor … - #2744
Open
HadiDawoud wants to merge 1 commit into
Open
HadiDawoud wants to merge 1 commit into
HadiDawoud wants to merge 1 commit into
Conversation
Collaborator
Coverage Report for CI Build 39966217298Coverage increased (+0.03%) to 75.147%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #2714
Implemented changes:
OcUrlUpdaterversion pattern from(\d\.\d\.\d*)(single-digit minor only) to(?<=href=")(\d+\.\d+\.\d+)(?![\w.-]), which now matches multi-digit minor versions(e.g.
4.10.0,4.22.19) and skips-rcfolders and partial version prefixes.OcUrlUpdater(same pattern asGitUrlUpdater).OcUrlUpdaterTestwith a mocked mirror index.Note: the issue suggested
href="(\d+\.\d+\.\d+)/", butWebsiteUrlUpdaterreadsmatcher.group()(full match), not a capture group. Switching it togroup(1)brokeGcLogAnalyzerUrlUpdaterandEclipseUrlUpdaterwhose patterns have no capture group.The lookaround form keeps the change local to
OcUrlUpdater.Testing instructions
mvn -pl url-updater -Dtest=OcUrlUpdaterTest test— passes with thenew pattern, fails with the old one (red→green verified).
versions newer than 4.9.59 (e.g. 4.22.19) are picked up.
Checklist for this PR
mvn clean testlocally all tests pass and build is successful#«issue-id»: «brief summary»In Progressand assigned to youpom.xmlfiles