Repository navigation
feat: port the media file player example to the client API - #399
Merged
Merged
Conversation
LocalTrack.closeAsync completes once the native track is released, after which a source it was made over may be closed.
One runtime in the CUSTOM audio mode replaces the two factories, a loopback signaling the hand-rolled offer, answer and candidate exchange, and the Swing VideoView the example's own panel. Statistics come from onStats, and a Record button records the received tracks with MediaRecorder.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #397; retarget to
mainonce it merges.MediaFilePlayerExampleon the client API: one runtime in theCUSTOMaudio mode instead of two factories, a loopback signaling instead of the hand-rolled offer/answer/candidate exchange, the SwingVideoView, andonStatsfor the metrics panel.MediaRecorder.LocalTrack.closeAsync(), so a track over aMediaFileSource's sources can be released before the file closes them.