Repository navigation
fix: keep WHIP/WHEP session credentials and bound signaling JSON - #430
Merged
Merged
Conversation
publish() and play() read the bearer token and timeout from the builder again once the answer arrived, so a builder changed in between sent the DELETE with other credentials than the POST and could leave the resource on the server.
The recursive parser had no depth limit, so a deeply nested member, even an unknown one, overflowed the stack with an Error that message handlers do not catch. Nesting beyond 64 levels and text beyond a MiB now throw IllegalArgumentException.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Whip.publish()andWhep.play()read the bearer token and timeout from the builder again once the answer arrived. A builder changed in between sent the DELETE with other credentials than the POST, which could leave the resource on the server. The session now keeps what it started with.Errorthat message handlers don't catch. Nesting beyond 64 levels and text beyond 1 MiB now throwIllegalArgumentException.