Repository navigation
fix: validate signaling JSON and ICE indexes strictly - #437
Merged
Merged
Conversation
The parser now follows RFC 8259 exactly: no raw control characters in strings, strict number syntax, finite numbers only, four-digit hex escapes, JSON whitespace only, no duplicate member names. sdpMLineIndex must be an integer from 0 to 65535 instead of being truncated by intValue().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The signaling JSON parser now follows RFC 8259 exactly: no raw control characters in strings, strict number syntax, finite numbers only, four-digit hex escapes, JSON whitespace only, no duplicate member names.
sdpMLineIndexmust be an integer from 0 to 65535;1.9and1e999were silently turned into 1 and 2147483647 byintValue().SignalMessage.of(RTCIceCandidate)checks the same range, sotoJson()never writes whatfromJson()rejects.