Repository navigation
fix(ic-certification): drop removed doc_auto_cfg feature attribute - #506
Closed
claude[bot] wants to merge 1 commit into
Closed
claude[bot] wants to merge 1 commit into
claude[bot] wants to merge 1 commit into
Conversation
The doc_auto_cfg nightly feature was merged into doc_cfg and removed from rustc, so docs.rs builds of this crate fail with `error[E0557]: feature has been removed`. Drop `doc_auto_cfg` from the cfg_attr and keep `doc_cfg`. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QaNdVsxCZhg3dDjpFHiRdZ
Contributor
|
Duplicate of #505 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Daniel Wong · Slack thread
Before:
packages/ic-certification/src/lib.rsenables the nightly featuredoc_auto_cfgwhen built with--cfg docsrs. That feature was merged intodoc_cfgand removed from rustc in 1.92.0 (rust-lang/rust#138907), so the docs.rs build of the crate (see build 4579659) fails witherror[E0557]: feature has been removedand no documentation is published.After: The crate attribute only enables
doc_cfg, which still exists on nightly, socargo +nightly docwith--cfg docsrssucceeds and docs.rs can build and publish the documentation again.How: remove
doc_auto_cfgfrom the#[cfg_attr(docsrs, feature(...))]line on line 4; nothing else changes. Verified locally withcargo check -p ic-certification(stable 1.88) andRUSTDOCFLAGS="--cfg docsrs" cargo +nightly doc -p ic-certification --no-deps, which reproduced the E0557 error before the change and passes after it.Generated by Claude Code