Repository navigation
fix(crawl): send obeyRobots=0 / useProxies=0 when explicitly False - #13
Merged
Merged
Conversation
crawl(obey_robots=False) and crawl(use_proxies=False) dropped the param, so the API default silently applied. Both are now tri-state (None omits, True/False send 1/0), matching use_canonical. The CLI gains --no-obey-robots, --no-use-proxies and --no-restrict-domain. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Nov 18, 2026
Merged
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In 3.4.0,
crawl(obey_robots=False)omitted theobeyRobotsparam, so an explicitFalsewas silently ignored and robots.txt was still obeyed (the API default).use_proxies=Falsehad the same "falsy flag dropped" bug.obey_robots/use_proxiesare now tri-state (Optional[bool] = None), likeuse_canonical:Noneomits the param (unchanged behaviour),Truesends1(unchanged),Falsenow sends0. Sync and async share_build_crawl_params, so both are fixed.db crawl:--obey-robots/--no-obey-robotsand--use-proxies/--no-use-proxies(default: omitted → API default), and--restrict-domain/--no-restrict-domain(it wasis_flagwithdefault=True, so it could never be turned off).restrict_domainalready sends0;use_canonicalalready tri-state; DQLnon_canonical_facts/no_dedup_articlesonly filterNone. The SDK has no bulk endpoint.Tests
tests/test_crawl.py: parametrized None/True/False forobeyRobotsanduseProxies, explicitobey_robots=False → obeyRobots=0,restrict_domain=False → 0, async variant.tests/test_cli_output.py: CLI defaults (None/None/True),--no-*→ False,--*→ True.🤖 Generated with Claude Code