Repository navigation
Point diffbot at 3.4.0rc0 for CI verification - #1
Merged
Merged
Conversation
…I skip Production pins stay on dify_plugin==0.11.0 with TODOs for diffbot 3.2.0/3.3.0. requirements-dev.txt installs the local SDK checkout editable. CI cannot see it, so tests/conftest.py skips SDK-dependent modules when diffbot is missing. Drop requests, which the plugin no longer uses. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
make_client() validates token/timeout and returns a Diffbot client behind a GuardedTransport that blocks private hosts. SDK errors map to redacted plugin errors. verify_token, extract options and crawl_download feature-detect the SDK 3.3.0 methods and fall back to client.request(). Enhance stays a plugin-side wrapper. Extract normalizes bare domains and gains caller-set options; web search drops the implicit short snippet; KG tools gain offset and size up to 100. Tests now run the real SDK over httpx.MockTransport. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…d fields crawl_start never watches and returns the job name. crawl_jobs lists, shows status, fetches results via crawl_download (or the /v3/crawl/data fallback), and deletes (labelled destructive, never retried). Provider gains request_timeout and block_private_hosts. test_sdk_wiring runs against the SDK with and without the 3.3.0 methods. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
The crawler answers a name over 30 characters with HTTP 200 + errorCode 505 and creates nothing (diffbot 3.2.0 does not surface that), so crawl_start now rejects such names up front. crawl_jobs results asked for num=limit, so 'truncated' could never be true; request limit+1 and default to the yaml's 100 rows. Fix KG search llm_descriptions that said 1000 instead of 100. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…rrorCode - JobError carries plain text, so APIError.message was empty and users saw 'Diffbot API error 500: request failed'; show the (redacted) reason. - The crawl_download fallback returned an HTTP 200 + errorCode body (e.g. an unknown job) as a result row; raise JobError like diffbot 3.3.0 does. - A non-JSON body escaped mapped_errors as a raw JSONDecodeError; map it. - The Enhance wrapper ignored HTTP 200 + errorCode (the old client checked it). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…an check Only CrawlJob and ExtractResponse are read by the plugin; the DqlResponse, WebSearchResponse, and NlpResponse fallbacks were dead code. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…thon -m pytest Without the SDK installed, 'import diffbot' resolves to the plugin's own diffbot/ directory as a namespace package when the repo root is on sys.path, so the SDK-dependent modules were not skipped. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
httpx stops reading proxy environment variables once a transport is passed explicitly, so wrapping httpx.HTTPTransport() in GuardedTransport silently dropped the proxy support the old requests client had. Build per-scheme proxied transports from the environment and respect NO_PROXY. Test mocks accept transport kwargs so the suite also passes with a proxy set. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Drops the tool YAML/implementation, its provider entry, the plugin-side enhance() transport wrapper and trim_enhance() shaper, the related tests, and every mention in README, PRIVACY, and SUBMISSION docs. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Describe the eight current tools (enhance_entity removed in 7323b7b), crawl_start/crawl_jobs behavior (background jobs, 30-character job names, destructive delete, account-wide job scope), the diffbot SDK + httpx transport replacing requests, the three credential fields, the four network domains, and a crawl-aware high-risk narrative. Drop the pre-SDK validator numbers. The package cannot be revalidated until diffbot 3.4.0 is on PyPI, so those results are marked TODO(sdk-release): rerun marketplace validator. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Drops the field, _as_bool and the toggle plumbing in GuardedTransport/make_client, and the self-hosted gateway wording in docs. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
The plugin version stays 0.1.0. The editable workspace path is gone. Marketplace submission stays a separate pull request.
The dependencies section still said the pin was not applied. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
shixish
marked this pull request as ready for review
November 18, 2026 21:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RC verification for the unison release.
This branch pins
diffbot==3.4.0rc0indiffbot/requirements.txtanddiffbot/pyproject.tomlso GitHub CI can install the published Python SDK release candidate from PyPI and run the suite.Do not merge until the stable
3.4.0SDK is published and the pin is switched to==3.4.0for the unison / marketplace publish. Thelanggenius/dify-pluginsmarketplace PR is still not part of this work and still needs a separate approval.