Skip to content

Drop SDK fallbacks; record the marketplace validator rerun on the 3.4.0 package - #2

Merged
shixish merged 2 commits into
mainfrom
chore/validator-rerun-3.4.0
Nov 18, 2026
Merged

shixish merged 2 commits into
mainfrom
chore/validator-rerun-3.4.0

Conversation

@shixish

@shixish shixish commented Nov 18, 2026

Copy link
Copy Markdown
Collaborator

Backlog "Rerun the Dify plugin validator". This doesn't open the langgenius/dify-plugins PR.

Commits

  1. Drop the SDK feature-detect fallbacks. diffbot==3.4.0 has verify_token, crawl_download, extract options, and the diffbot.types TypedDicts natively. So the client.request() fallbacks in diffbot/tools/sdk.py and the whole of tools/sdk_types.py are removed (-127 lines). The wiring tests lose the "legacy SDK" parametrization that only existed to exercise those fallbacks. No behavior change with 3.4.0. SUBMISSION.md listed this as a pre-PR step.
  2. Record the validator rerun. SUBMISSION.md: every TODO(sdk-release) is replaced with the results below. CHANGELOG: Unreleased note.

Package and validator (18 Nov 2026)

  • dify plugin package (CLI v0.6.15) → diffbot-0.1.0.difypkg, 48,816 bytes, 32 files, dify plugin checksum 7c901257…e3e91
  • dify-marketplace-toolkit @ 83ee707, validate-difypkg.py --pr-body-file: exit 0, 0 blocking failures, 4 warning categories (no OSV vulnerabilities; no literal hostnames, which is expected for an SDK plugin; INVALID_TOKEN is an error string; the credential-flow notes in sdk.py are covered by redaction). All of these are explained in the PR body draft.
  • test-plugin-install.py with INSTALL_METHOD=serverless: success

Still pending before the marketplace PR (in SUBMISSION.md)

The live smoke test with a real token (none was available here), installs on Dify CE and Cloud, PRIVACY.md crawl rows, the logo OK, and a privacy review.

🤖 Generated with Claude Code

shixish and others added 2 commits November 18, 2026 12:23
verify_token, crawl_download and extract options are native in 3.4.0, and
diffbot.types ships the response TypedDicts, so the client.request()
fallbacks and tools/sdk_types.py go. The wiring tests lose the 'legacy SDK'
parametrization that exercised them.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Rebuilt diffbot-0.1.0.difypkg (dify CLI v0.6.15) and reran the
dify-marketplace-toolkit validator: exit 0, 0 blocking failures, serverless
start-up OK. Replace the TODO(sdk-release) markers with the results; the
live smoke test is still pending (needs a real token).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@shixish
shixish merged commit 7cfde61 into main Nov 18, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant