Repository navigation
Drop SDK fallbacks; record the marketplace validator rerun on the 3.4.0 package - #2
Merged
Merged
Conversation
verify_token, crawl_download and extract options are native in 3.4.0, and diffbot.types ships the response TypedDicts, so the client.request() fallbacks and tools/sdk_types.py go. The wiring tests lose the 'legacy SDK' parametrization that exercised them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Rebuilt diffbot-0.1.0.difypkg (dify CLI v0.6.15) and reran the dify-marketplace-toolkit validator: exit 0, 0 blocking failures, serverless start-up OK. Replace the TODO(sdk-release) markers with the results; the live smoke test is still pending (needs a real token). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backlog "Rerun the Dify plugin validator". This doesn't open the
langgenius/dify-pluginsPR.Commits
diffbot==3.4.0hasverify_token,crawl_download, extract options, and thediffbot.typesTypedDicts natively. So theclient.request()fallbacks indiffbot/tools/sdk.pyand the whole oftools/sdk_types.pyare removed (-127 lines). The wiring tests lose the "legacy SDK" parametrization that only existed to exercise those fallbacks. No behavior change with 3.4.0. SUBMISSION.md listed this as a pre-PR step.TODO(sdk-release)is replaced with the results below. CHANGELOG: Unreleased note.Package and validator (18 Nov 2026)
dify plugin package(CLI v0.6.15) →diffbot-0.1.0.difypkg, 48,816 bytes, 32 files,dify plugin checksum7c901257…e3e91dify-marketplace-toolkit@83ee707,validate-difypkg.py --pr-body-file: exit 0, 0 blocking failures, 4 warning categories (no OSV vulnerabilities; no literal hostnames, which is expected for an SDK plugin;INVALID_TOKENis an error string; the credential-flow notes insdk.pyare covered by redaction). All of these are explained in the PR body draft.test-plugin-install.pywithINSTALL_METHOD=serverless: successStill pending before the marketplace PR (in SUBMISSION.md)
The live smoke test with a real token (none was available here), installs on Dify CE and Cloud, PRIVACY.md crawl rows, the logo OK, and a privacy review.
🤖 Generated with Claude Code