Repository navigation
fix(credentials): mask encoded secrets in service logs without breaking saved credentials - #143
Merged
Merged
Conversation
…ecrets too short to mask
0libote
force-pushed
the
fix/secret-redaction
branch
from
November 14, 2026 11:39
61e540e to
74d0f80
Compare
This was referenced Nov 14, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Services logs previously masked literal secret text only, leaving common encoded forms readable in persisted logs. The writer now shares the Vault's encoded variants and handles values split across writes, including existing short service passwords. Replacement markers are written in one pass so one secret cannot rewrite another secret's redaction.
The shared module resolves correctly in both the source checkout and the image's sibling
/opt/t3-servicesand/opt/t3-setupdirectories. Existing Vault entries, gateway keys and external password policies remain compatible.Validation:
Original encoded-redaction work contributed by @0libote; maintainer review fixes retain that work and remove the incompatible blanket secret-length restriction.