Skip to content

fix(credentials): mask encoded secrets in service logs without breaking saved credentials - #143

Merged
dizys merged 3 commits into
dizys:mainfrom
0libote:fix/secret-redaction
Nov 14, 2026
Merged

dizys merged 3 commits into
dizys:mainfrom
0libote:fix/secret-redaction

Conversation

@0libote

@0libote 0libote commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

Services logs previously masked literal secret text only, leaving common encoded forms readable in persisted logs. The writer now shares the Vault's encoded variants and handles values split across writes, including existing short service passwords. Replacement markers are written in one pass so one secret cannot rewrite another secret's redaction.

The shared module resolves correctly in both the source checkout and the image's sibling /opt/t3-services and /opt/t3-setup directories. Existing Vault entries, gateway keys and external password policies remain compatible.

Validation:

  • All 385 focused Services, credentials, credential-model and gateway service tests passed.
  • New regressions reproduce the original image import failure, short-secret leakage and incompatible credential validation before the fixes.
  • The regression suite tests every chunk split for literal, base64, URL, form and JSON-escaped values, and imports the modules in a temporary copy of the installed image layout.
  • Merged current main, including (1/8) fix(tests): expect Claude's 1M Gemini context window in native smoke #148's smoke correction, for fresh native and image CI.

Original encoded-redaction work contributed by @0libote; maintainer review fixes retain that work and remove the incompatible blanket secret-length restriction.

@0libote
0libote force-pushed the fix/secret-redaction branch from 61e540e to 74d0f80 Compare November 14, 2026 11:39
@0libote

0libote commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor Author

Fifth (5 of 8), after #148, #145, #146, #144. Checked, lands clean.

@0libote 0libote changed the title fix(credentials): mask encoded secret forms in service logs, refuse secrets too short to mask (5/8) fix(credentials): mask encoded secret forms in service logs, refuse secrets too short to mask Nov 14, 2026
@dizys dizys changed the title (5/8) fix(credentials): mask encoded secret forms in service logs, refuse secrets too short to mask fix(credentials): mask encoded secrets in service logs without breaking saved credentials Nov 14, 2026
@dizys
dizys merged commit 89b28c9 into dizys:main Nov 14, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants