Repository navigation
(8/8) chore(setup): share release bounds, atomic writes, capped reads, chatter JSON - #147
Merged
Merged
Conversation
…ter JSON Extract single homes for the limits and predicates both release stacks enforce, one atomic tmp+rename writer for the setup store and instruction editors, one capped-read module for skill, instruction and settings reads, and one chatter-tolerant JSON parse per image layer. Document the single-writer contract on the native-settings queues instead of adding a cross-process lock no external writer would honor.
Contributor
Author
|
Last one (8 of 8). It's the big pure refactor, so it sits on top of everything else. Checked the full order, no conflicts. |
Preserve the exact failing transfer stage, HTTP status and assertion output in the existing smoke diagnostics. Keep all upload, checksum and Trash assertions intact.
Read an exact Node engine version from each source tag and pass that official builder image to both architecture jobs. Stable and Nightly can advance independently without breaking ARM64 native SEA packaging. Reject malformed metadata and preserve the bundled runtime Node configuration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release bounds, atomic file writers, capped readers and CLI JSON parsing were duplicated across the runtime, harness and Setup layers. Consolidate their shared contracts while keeping imports within each installed image layer. Document the native-settings queues' single-writer and revision-checking behavior.
Native CI now reads the exact Node version from each upstream release tag's package manifest and passes its official builder image into both architecture jobs. Stable and Nightly can require different compiler versions, as they do for Node 26.12.1 and 26.13.1. Invalid or unavailable metadata stops planning. Preserve upstream's native ARM64 SEA packaging and the existing container runtime Node configuration.
Retain the Files transfer smoke check's stage, HTTP status and assertion output in the existing diagnostics log. Its 20 MiB upload, atomic publication, checksum, Trash and restore assertions remain intact.
Validation:
Thanks to @0libote for the original helper consolidation. Maintainer review adds release-specific compiler selection and retained Files failure diagnostics.