Add pcov extension to PHP 8.5 images - #28
Merged
Merged
Conversation
Install the php8.5-pcov package (code coverage driver) in the PHP 8.5 CLI and FPM Dockerfiles and mark pcov as available for 8.5 in the README extension table. Images for 7.1-8.4 already ship pcov. pcov requires PHP >= 7.1, so the 5.6 and 7.0 images are left unchanged. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KXMvf7N1S6F7E4fQKP96sA
The cli and fpm smoke tests now run a test-pcov-* check that fails when the pcov extension is missing from an image built for PHP >= 7.1. Images older than 7.1 are exempt, since pcov does not support them. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KXMvf7N1S6F7E4fQKP96sA
f3l1x
force-pushed
the
claude/install-pcov-extension-x59vfl
branch
from
September 9, 2026 06:16
7b33b38 to
e83fbc6
Compare
f3l1x
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebased on current
master, which already ships pcov for 7.1-8.4. What is left:php8.5-pcovin8.5/Dockerfileand8.5-fpm/Dockerfile, so every image that can have pcov now does.test-pcov-%smoke test, called fromtest-cli-%andtest-fpm-%, that fails when pcov is missing from an image built for PHP >= 7.1.5.6 and 7.0 are left unchanged: pcov requires PHP >= 7.1.0, so no
php5.6-pcov/php7.0-pcovpackage exists. The version guard intest-pcov-%exempts them.Testing
CI run 105 is green: all 24 images build, and
make test-cli-8.5/make test-fpm-8.5pass with the new pcov assertion (PHP 8.5.10, pcov loaded).🤖 Generated with Claude Code
https://claude.ai/code/session_01KXMvf7N1S6F7E4fQKP96sA