Skip to content

Match and link Spear Pillar ground objects - #129

Merged
mparisi20 merged 3 commits into
doldecomp:mainfrom
MarioLover63:tengan
Oct 7, 2026
Merged

mparisi20 merged 3 commits into
doldecomp:mainfrom
MarioLover63:tengan

Conversation

@MarioLover63

Copy link
Copy Markdown
Contributor

remaking the pull request because apparently force pushing prevents prs from being reopened

@decomp-dev

decomp-dev Bot commented Oct 7, 2026

Copy link
Copy Markdown

Report for RSBE01_02 (b0675c6 - a210530)

Total functions: 92523 (-1)
📈 Matched code: 1.25% (+0.05%, +7368 bytes)
📈 Linked code: 1.05% (+0.03%, +5228 bytes)
Total data: 5667488 bytes (-4 bytes)
📈 Matched data: 14.60% (+0.01%, +840 bytes)
📈 Linked data: 14.92% (+0.04%, +2540 bytes)

✅ 64 new matches
Unit Item Bytes Before After
st_tengan/mo_stage/st_tengan/gr_tengan_floor grTenganFloor::setMotion(unsigned char, bool, unsigned long, float*) +1096 0.00% 100.00%
st_tengan/mo_stage/st_tengan/gr_tengan_ashiba grTenganAshiba::updateMove(float) +852 0.00% 100.00%
st_tengan/mo_stage/st_tengan/gr_tengan_floor grTenganFloor::updateActive(float) +832 0.00% 100.00%
st_tengan/mo_stage/st_tengan/gr_tengan_bg .data +792 0.00% 100.00%
st_tengan/mo_stage/st_tengan/st_tengan stTengan::createObjFloor(int) +432 0.00% 100.00%
st_tengan/mo_stage/st_tengan/st_tengan stTengan::createObjSkyLaser(int) +328 0.00% 100.00%
st_tengan/mo_stage/st_tengan/gr_tengan_bg grTenganBg::update(float) +264 0.00% 100.00%
st_tengan/mo_stage/st_tengan/gr_tengan_floor grTenganFloor::create(int, const char*, const char*) +260 0.00% 100.00%
st_tengan/mo_stage/st_tengan/st_tengan stTengan::createObjAshiba(int) +252 0.00% 100.00%
st_tengan/mo_stage/st_tengan/st_tengan stTengan::eventRebuildStageUpdate() +252 0.00% 100.00%
st_tengan/mo_stage/st_tengan/st_tengan stTengan::createObjBg(int) +220 0.00% 100.00%
st_tengan/mo_stage/st_tengan/gr_tengan grTengan::create(int, const char*, const char*) +212 0.00% 100.00%
st_tengan/mo_stage/st_tengan/st_tengan stTengan::createObjEnkei(int) +208 0.00% 100.00%
st_tengan/mo_stage/st_tengan/gr_tengan_bg grTenganBg::create(int, const char*, const char*) +208 0.00% 100.00%
st_tengan/mo_stage/st_tengan/gr_tengan_ashiba grTenganAshiba::create(int, const char*, const char*) +188 0.00% 100.00%
st_tengan/mo_stage/st_tengan/gr_tengan_ashiba grTenganAshiba::grTenganAshiba(const char*) +188 0.00% 100.00%
st_tengan/mo_stage/st_tengan/gr_tengan_ashiba grTenganAshiba::updateCallBack(float) +168 0.00% 100.00%
st_tengan/mo_stage/st_tengan/st_tengan stClassInfoImpl<21, stTengan>::~stClassInfoImpl() +116 0.00% 100.00%
st_tengan/mo_stage/st_tengan/gr_tengan_floor grTenganFloor::update(float) +116 0.00% 100.00%
st_tengan/mo_stage/st_tengan/gr_tengan_ashiba grTenganAshiba::update(float) +116 0.00% 100.00%
st_tengan/mo_stage/st_tengan/st_tengan __sinit_\st_tengan_cpp +100 0.00% 100.00%
st_tengan/mo_stage/st_tengan/gr_tengan grTengan::setTgtNode(const char*) +92 0.00% 100.00%
st_tengan/mo_stage/st_tengan/gr_tengan grTengan::~grTengan() +88 0.00% 100.00%
st_tengan/mo_stage/st_tengan/gr_tengan_bg grTenganBg::~grTenganBg() +88 0.00% 100.00%
st_tengan/mo_stage/st_tengan/gr_tengan_floor grTenganFloor::~grTenganFloor() +88 0.00% 100.00%
st_tengan/mo_stage/st_tengan/gr_tengan_ashiba grTenganAshiba::~grTenganAshiba() +88 0.00% 100.00%
st_tengan/mo_stage/st_tengan/gr_tengan grTengan::grTengan(const char*) +76 0.00% 100.00%
st_tengan/mo_stage/st_tengan/st_tengan stTengan::create() +52 0.00% 100.00%
st_tengan/mo_stage/st_tengan/st_tengan stClassInfoImpl<21, stTengan>::create() +52 0.00% 100.00%
st_tengan/mo_stage/st_tengan/gr_tengan_floor grTenganFloor::updatePreBuild(float) +48 0.00% 100.00%

...and 34 more new matches

📈 10 improvements in unmatched items
Unit Item Bytes Before After
st_tengan/mo_stage/st_tengan/st_tengan stTengan::createObj() +4235 0.00% 74.37%
st_tengan/mo_stage/st_tengan/gr_tengan .data +632 0.00% 98.77%
st_tengan/mo_stage/st_tengan/gr_tengan_floor .data +489 0.00% 90.04%
st_tengan/mo_stage/st_tengan/gr_tengan_ashiba .data +476 0.00% 88.97%
st_tengan/mo_stage/st_tengan/st_tengan stTengan::createObjDialga(int) +341 0.00% 50.49%
st_tengan/mo_stage/st_tengan/st_tengan stTengan::~stTengan() +329 0.00% 80.82%
st_tengan/mo_stage/st_tengan/st_tengan stTengan::updateEvent(float) +270 0.00% 10.69%
st_tengan/mo_stage/st_tengan/st_tengan stTengan::stTengan() +254 0.00% 50.08%
st_tengan/mo_stage/st_tengan/st_tengan .rodata +124 0.00% 50.00%
st_tengan/mo_stage/st_tengan/st_tengan .data +13 0.00% 0.64%

@mparisi20
mparisi20 merged commit 2f12dde into doldecomp:main Oct 7, 2026
1 check passed
humboldt123 referenced this pull request in humboldt123/brawl Oct 7, 2026
Took upstream's four matched gr_tengan_* units and config. Kept our st_tengan.h/.cpp:
it has real field names and 8 event functions upstream lacks, and matches better
than upstream's version (47.35% vs 29.92%, 26 vs 23 functions, no function worse).
Kept our corrected gfModelAnimation symbol names where upstream still had the old ones.
All 127 hashes OK.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants