Skip to content

MSound/MSoundSE: correct the Kamome sound group - #232

Merged
Mrkol merged 1 commit into
doldecomp:mainfrom
gitRasheed:pr/MSound-MSoundSE
Oct 1, 2026
Merged

Mrkol merged 1 commit into
doldecomp:mainfrom
gitRasheed:pr/MSound-MSoundSE

Conversation

@gitRasheed

Copy link
Copy Markdown
Contributor

Gives the Kamome sound group its distinct sound IDs, random shift and ensemble values from the target, and includes DummyStrings for the two literals the target puts before this TU's strings.

@decomp-dev

decomp-dev Bot commented Sep 30, 2026

Copy link
Copy Markdown

Report for GMSJ01 (2749193 - b83444a)

📈 Matched data: 66.26% (+0.26%, +1696 bytes)

✅ 2 new matches
Unit Item Bytes Before After
mario/MSound/MSoundSE .rodata +17 98.76% 100.00%
mario/MSound/MSoundSE .sdata2 +5 98.93% 100.00%
📈 2 improvements in unmatched items
Unit Item Bytes Before After
mario/MSound/MSoundSE MSoundSESystem::MSoundSE::construct() +13 99.71% 99.99%
mario/MSound/MSoundSE MSSetSoundTL<MSSetSoundGrp>::MSSetSoundTL(unsigned long, const char*, MSSetSoundGrp*, unsigned char, unsigned char, unsigned char, unsigned char, float, unsigned char, float, float, float, float, float, long, float, long, float, float, float, bool) 0 99.68% 99.79%

Report for GMSP01 (2749193 - b83444a)

📈 3 improvements in unmatched items
Unit Item Bytes Before After
mario/MSound/MSoundSE .rodata +16 98.30% 99.54%
mario/MSound/MSoundSE MSoundSESystem::MSoundSE::construct() +7 97.78% 97.92%
mario/MSound/MSoundSE .sdata2 +4 93.78% 94.82%

@Mrkol
Mrkol merged commit f2e896d into doldecomp:main Oct 1, 2026
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants