Skip to content

GC2D/CardSave: fix inverted save-time check and selection signedness - #235

Merged
Mrkol merged 1 commit into
doldecomp:mainfrom
gitRasheed:pr/GC2D-CardSave
Oct 1, 2026
Merged

Mrkol merged 1 commit into
doldecomp:mainfrom
gitRasheed:pr/GC2D-CardSave

Conversation

@gitRasheed

Copy link
Copy Markdown
Contributor

The save-time check in execMovement_ stored the states on the wrong branches, and waitForSelect3 copied the s8 selection into a u8.

@decomp-dev

decomp-dev Bot commented Sep 30, 2026

Copy link
Copy Markdown

Report for GMSJ01 (2749193 - b3840d6)

📈 2 improvements in unmatched items
Unit Item Bytes Before After
mario/GC2D/CardSave TCardSave::waitForSelect3(TEProgress, TEProgress, TEProgress) +18 99.11% 99.86%
mario/GC2D/CardSave TCardSave::execMovement_() 0 99.69% 99.69%

Report for GMSP01 (2749193 - b3840d6)

📈 2 improvements in unmatched items
Unit Item Bytes Before After
mario/GC2D/CardSave TCardSave::waitForSelect3(TEProgress, TEProgress, TEProgress) +18 95.65% 96.38%
mario/GC2D/CardSave TCardSave::execMovement_() 0 99.01% 99.01%

@Mrkol
Mrkol merged commit e024d5c into doldecomp:main Oct 1, 2026
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants